devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Romain Izard <romain.izard.pro@gmail.com>
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: Fix WLAN interrupt line for AM335x EVM-SK
Date: Wed, 20 May 2015 09:52:23 -0700	[thread overview]
Message-ID: <20150520165223.GW10274@atomide.com> (raw)
In-Reply-To: <1431502655-23255-1-git-send-email-romain.izard.pro@gmail.com>

* Romain Izard <romain.izard.pro@gmail.com> [150513 00:39]:
> While Sitara AM335x SoCs are very close to OMAP SoCs, the 32-line GPIO
> controllers are numbered from 0 on AM335x and from 1 on OMAP. But when
> the configuration for the TI WLAN controllers was converted from
> platform data to device tree, this detail was overlooked, as 10 boards
> were using OMAP with the WL12xx and WL18xx controllers, and only one
> was based on AM335x.
> 
> This invalid configuration prevents the WL1271 module on the AM335x
> EVM-SK from notifying interrupts to the SoC, and breaks the wlan driver.
> 
> The DTS must be corrected to use the correct GPIO controller.
> 
> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
> ---
>  arch/arm/boot/dts/am335x-evmsk.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/am335x-evmsk.dts b/arch/arm/boot/dts/am335x-evmsk.dts
> index 87fc7a35e802..156d05efcb70 100644
> --- a/arch/arm/boot/dts/am335x-evmsk.dts
> +++ b/arch/arm/boot/dts/am335x-evmsk.dts
> @@ -654,7 +654,7 @@
>  	wlcore: wlcore@2 {
>  		compatible = "ti,wl1271";
>  		reg = <2>;
> -		interrupt-parent = <&gpio1>;
> +		interrupt-parent = <&gpio0>;
>  		interrupts = <31 IRQ_TYPE_LEVEL_HIGH>; /* gpio 31 */
>  		ref-clock-frequency = <38400000>;
>  	};

Applying into omap-for-v4.1/fixes thanks.

Tony

      reply	other threads:[~2015-05-20 16:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-13  7:37 [PATCH] ARM: dts: Fix WLAN interrupt line for AM335x EVM-SK Romain Izard
2015-05-20 16:52 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150520165223.GW10274@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=romain.izard.pro@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).