From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v3 3/5] ata: add Broadcom AHCI SATA3 driver for STB chips Date: Thu, 21 May 2015 18:20:59 -0400 Message-ID: <20150521222059.GM4914@htj.duckdns.org> References: <1431473303-18873-1-git-send-email-computersforpeace@gmail.com> <1431473303-18873-4-git-send-email-computersforpeace@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Fabio Estevam Cc: Brian Norris , Kishon Vijay Abraham I , Mark Rutland , "devicetree@vger.kernel.org" , Hans de Goede , Florian Fainelli , Pawel Moll , Ian Campbell , Kevin Cernekee , linux-kernel , linux-ide@vger.kernel.org, Rob Herring , bcm-kernel-feedback-list@broadcom.com, Gregory Fong , Kumar Gala , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On Thu, May 21, 2015 at 07:16:07PM -0300, Fabio Estevam wrote: > On Tue, May 12, 2015 at 8:28 PM, Brian Norris > wrote: > > > + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ahci"); > > + ahci = devm_ioremap_resource(&pdev->dev, res); > > + if (IS_ERR(ahci)) > > + return 0; > > You should propagate 'return PTR_ERR(ahci)' instead. Brian, can you please update the patch? Thanks. -- tejun