From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v10 4/5] edac: Add APM X-Gene SoC EDAC driver Date: Fri, 22 May 2015 10:46:25 +0200 Message-ID: <20150522084625.GE23022@pd.tnic> References: <1431991481-25684-1-git-send-email-lho@apm.com> <1431991481-25684-4-git-send-email-lho@apm.com> <1431991481-25684-5-git-send-email-lho@apm.com> <4456746.y9FVaqRogk@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <4456746.y9FVaqRogk@wuerfel> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: Loc Ho , dougthompson-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, linux-edac-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, patches-qTEPVZfXA3Y@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, May 22, 2015 at 10:23:11AM +0200, Arnd Bergmann wrote: > > +static int edac_mc_idx; > > +static int edac_mc_active_mask; > > +static int edac_mc_registered_mask; > > +static DEFINE_MUTEX(xgene_edac_mc_lock); > > It would also be best to avoid global variables, but it seems that at > least the edac_mc_idx is needed to work with the EDAC subsystem. > Maybe Boris has an idea for how to avoid it. Right, so AFAICT this is used in edac_mc_alloc(edac_mc_idx++ and basically we're supplying the memory controller numbers in the order we're calling xgene_edac_mc_add(). Perhaps we need to make the memory controller numbering explicit with DT... -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html