From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH v3.1 4/4] of/platform: Use platform_device interface Date: Sun, 24 May 2015 12:29:15 -0700 Message-ID: <20150524192915.GA7170@kroah.com> References: <1429719261-18024-1-git-send-email-ricardo.ribalda@gmail.com> <1429719261-18024-5-git-send-email-ricardo.ribalda@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1429719261-18024-5-git-send-email-ricardo.ribalda-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ricardo Ribalda Delgado Cc: Grant Likely , Rob Herring , Andrew Morton , Jakub Sitnicki , Vivek Goyal , Bjorn Helgaas , Jiang Liu , Mike Travis , Thierry Reding , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, May 15, 2015 at 01:52:10PM +0200, Ricardo Ribalda Delgado wrote: > of_platform_device_create_pdata() was using of_device_add() to create > the devices, but of_platform_device_destroy was using > platform_device_unregister() to free them. > > of_device_add(), do not call insert_resource(), which initializes the > parent field of the resource structure, needed by release_resource(), > called by of_platform_device_destroy(). This leads to a NULL pointer > deference. > > Instead of fixing the NULL pointer deference, what could hide other bugs, > this patch, replaces of_device_add() with platform_device_data(). > > Signed-off-by: Ricardo Ribalda Delgado > Acked-by: Rob Herring > --- > > v3.1 Fix comments by Rob Herring, thanks! 3.1? Please resend the whole series, this is a mess, I can't find where this goes at all... greg k-h -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html