From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, Arnaud Ebalard <arno@natisbad.org>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Jason Cooper <jason@lakedaemon.net>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Tawfik Bayouk <tawfik@marvell.com>,
Lior Amsalem <alior@marvell.com>,
Nadav Haklai <nadavh@marvell.com>,
Eran Ben-Avi <benavi@marvell.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 02/16] crypto: add a new driver for Marvell's CESA
Date: Mon, 25 May 2015 10:10:16 +0200 [thread overview]
Message-ID: <20150525101016.252a1dc0@bbrezillon> (raw)
In-Reply-To: <20150525075812.GA28689@gondor.apana.org.au>
Hi Herbert,
On Mon, 25 May 2015 15:58:12 +0800
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Fri, May 22, 2015 at 03:33:48PM +0200, Boris Brezillon wrote:
> >
> > +static int mv_cesa_sha1_export(struct ahash_request *req, void *out)
> > +{
> > + struct sha1_state *out_state = out;
> > + struct crypto_ahash *ahash = crypto_ahash_reqtfm(req);
> > + struct mv_cesa_ahash_req *creq = ahash_request_ctx(req);
> > + unsigned int digsize = crypto_ahash_digestsize(ahash);
> > +
> > + out_state->count = creq->len;
> > + memcpy(out_state->state, creq->state, digsize);
> > + memset(out_state->buffer, 0, sizeof(out_state->buffer));
> > + if (creq->cache)
> > + memcpy(out_state->buffer, creq->cache, creq->cache_ptr);
> > +
> > + return 0;
> > +}
>
> Where is the import function?
Yep, I noticed that after submitting this version. I guess I only
needed the import function for my test cases and thus forgot to
implement the import function.
Anyway, I just added the the import functions (they'll be available in
my v4).
Best Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-05-25 8:10 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 13:33 [PATCH v3 0/2] crypto: add a new driver for Marvell's CESA Boris Brezillon
2015-05-22 13:33 ` [PATCH v3 01/16] crypto: mv_cesa: request registers memory region Boris Brezillon
2015-05-25 12:56 ` Herbert Xu
2015-05-22 13:33 ` [PATCH v3 06/16] crypto: marvell/CESA: add MD5 support Boris Brezillon
2015-05-22 13:33 ` [PATCH v3 07/16] crypto: marvell/CESA: add SHA256 support Boris Brezillon
2015-05-22 13:33 ` [PATCH v3 10/16] crypto: marvell/CESA: add support for Orion SoCs Boris Brezillon
2015-05-22 13:33 ` [PATCH v3 11/16] crypto: marvell/CESA: add support for Kirkwood SoCs Boris Brezillon
2015-05-22 13:33 ` [PATCH v3 13/16] ARM: marvell/dt: add crypto node to armada-xp.dtsi Boris Brezillon
2015-05-25 15:15 ` Gregory CLEMENT
2015-05-22 13:34 ` [PATCH v3 14/16] ARM: marvell/dt: enable crypto on armada-xp-gp Boris Brezillon
[not found] ` <1432301642-11470-15-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2015-05-25 15:10 ` Gregory CLEMENT
2015-05-26 8:59 ` Boris Brezillon
2015-05-26 9:22 ` Imre Kaloz
2015-05-26 11:57 ` Andrew Lunn
2015-05-27 10:20 ` Gregory CLEMENT
2015-05-27 11:23 ` Thomas Petazzoni
2015-05-27 11:33 ` Gregory CLEMENT
[not found] ` <5565AB91.1010008-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2015-05-27 11:38 ` Thomas Petazzoni
[not found] ` <1432301642-11470-1-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2015-05-22 13:33 ` [PATCH v3 02/16] crypto: add a new driver for Marvell's CESA Boris Brezillon
[not found] ` <1432301642-11470-3-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2015-05-25 7:58 ` Herbert Xu
2015-05-25 8:10 ` Boris Brezillon [this message]
2015-05-25 8:12 ` Herbert Xu
2015-05-25 10:44 ` Imre Kaloz
2015-05-25 11:08 ` Boris Brezillon
2015-05-25 11:13 ` Imre Kaloz
2015-05-25 11:17 ` Boris Brezillon
2015-05-27 8:13 ` Imre Kaloz
2015-05-25 8:05 ` Herbert Xu
2015-05-25 8:18 ` Boris Brezillon
2015-05-25 8:25 ` Herbert Xu
2015-05-22 13:33 ` [PATCH v3 03/16] crypto: marvell/CESA: add TDMA support Boris Brezillon
2015-05-22 13:33 ` [PATCH v3 04/16] crypto: marvell/CESA: add DES support Boris Brezillon
2015-05-22 13:33 ` [PATCH v3 05/16] crypto: marvell/CESA: add Triple-DES support Boris Brezillon
2015-05-22 13:33 ` [PATCH v3 08/16] crypto: marvell/CESA: add support for all armada SoCs Boris Brezillon
2015-05-22 13:33 ` [PATCH v3 09/16] crypto: marvell/CESA: add allhwsupport module parameter Boris Brezillon
2015-05-22 13:33 ` [PATCH v3 12/16] crypto: marvell/CESA: update DT bindings documentation Boris Brezillon
2015-05-22 13:34 ` [PATCH v3 15/16] ARM: marvell/dt: add crypto node to armada 370 dtsi Boris Brezillon
2015-05-25 15:33 ` Gregory CLEMENT
2015-05-26 9:03 ` Boris Brezillon
2015-05-26 9:10 ` Thomas Petazzoni
2015-05-26 9:36 ` Boris Brezillon
2015-05-22 13:34 ` [PATCH v3 16/16] ARM: marvell/dt: add crypto node to kirkwood dtsi Boris Brezillon
2015-05-25 15:39 ` Gregory CLEMENT
2015-05-25 16:46 ` Jason Cooper
2015-05-25 18:43 ` Boris Brezillon
2015-05-26 9:06 ` Jason Cooper
2015-05-26 9:10 ` Boris Brezillon
2015-05-26 9:42 ` Jason Cooper
2015-05-22 14:02 ` [PATCH v3 0/2] crypto: add a new driver for Marvell's CESA Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150525101016.252a1dc0@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=arno@natisbad.org \
--cc=benavi@marvell.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregory.clement@free-electrons.com \
--cc=herbert@gondor.apana.org.au \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=linux-crypto@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nadavh@marvell.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tawfik@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).