From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sascha Hauer Subject: Re: [PATCH 5/5] clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS Date: Tue, 26 May 2015 11:41:40 +0200 Message-ID: <20150526094140.GH6325@pengutronix.de> References: <1432192376-6712-1-git-send-email-jamesjj.liao@mediatek.com> <1432192376-6712-6-git-send-email-jamesjj.liao@mediatek.com> <20150526080516.GG6325@pengutronix.de> <1432631475.15597.29.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1432631475.15597.29.camel@mtksdaap41> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: James Liao Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mike Turquette , srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Stephen Boyd , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ricky Liang , Rob Herring , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Henry Chen , Sascha Hauer , Matthias Brugger , Yingjoe Chen , Eddie Huang , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, May 26, 2015 at 05:11:15PM +0800, James Liao wrote: > Hi Sascha, > > On Tue, 2015-05-26 at 10:05 +0200, Sascha Hauer wrote: > > On Thu, May 21, 2015 at 03:12:56PM +0800, James Liao wrote: > > > +static void __init mtk_clk_register_apmixedsys_special(struct device_node *node, > > > + struct clk_onecell_data *clk_data) > > > +{ > > > + void __iomem *base; > > > + struct clk *clk; > > > + > > > + base = of_iomap(node, 0); > > > + if (!base) { > > > + pr_err("%s(): ioremap failed\n", __func__); > > > + return; > > > + } > > > + > > > + clk = mtk_clk_register_ref2usb_tx("ref2usb_tx", base + 0x8); > > > > The function seems to be for one special clock only. Why do you pass the > > name to it? They will never be called with another name, right? > > This function decides clock name and associates clock ID for special > clocks. In fact there may be another "special clocks" need to add into > apmixedsys. I think it's a better way to group clock names and clock IDs > in the same function for maintenance. How can a function with ref2usb_tx in its name ever register a clock with another name? Then it seems the function name is wrong. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |