From: Mark Rutland <mark.rutland@arm.com>
To: Irina Tirdea <irina.tirdea@intel.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Bastien Nocera <hadess@hadess.net>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Octavian Purdila <octavian.purdila@intel.com>
Subject: Re: [PATCH 6/9] input: goodix: write configuration data to device
Date: Thu, 28 May 2015 14:21:33 +0100 [thread overview]
Message-ID: <20150528132133.GI23176@leverpostej> (raw)
In-Reply-To: <1432817265-23891-7-git-send-email-irina.tirdea@intel.com>
On Thu, May 28, 2015 at 01:47:42PM +0100, Irina Tirdea wrote:
> Goodix devices can be configured by writing this information
> to the device at init. The configuration data can
> be provided through the ACPI/device tree property
> "device-config". If "device-config" is not set, the default
> device configuration will be used.
>
> Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
> Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
> ---
> .../bindings/input/touchscreen/goodix.txt | 5 +
> drivers/input/touchscreen/goodix.c | 143 +++++++++++++++++++++
> 2 files changed, 148 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> index 7137881..9e4ff69 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> @@ -15,6 +15,11 @@ Required properties:
> - irq-gpio : GPIO pin used for IRQ
> - reset-gpio : GPIO pin used for reset
>
> +Optional properties:
> +
> + - device-config : device configuration information (specified as byte
> + array). Maximum size is 240 bytes.
Generally we frown on passing opaque data.
What exactly is encoded in device-config? The description is very vague.
Does this correspond to anything in a data sheet or manual?
Mark.
next prev parent reply other threads:[~2015-05-28 13:21 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 12:47 [PATCH 0/9] Goodix touchscreen enhancements Irina Tirdea
2015-05-28 12:47 ` [PATCH 1/9] input: goodix: fix alignment issues Irina Tirdea
2015-06-04 12:48 ` Bastien Nocera
2015-06-05 16:49 ` Dmitry Torokhov
2015-06-05 17:07 ` Tirdea, Irina
2015-06-05 17:17 ` Joe Perches
2015-06-05 17:31 ` Dmitry Torokhov
2015-05-28 12:47 ` [PATCH 2/9] input: goodix: fix variable length array warning Irina Tirdea
2015-05-28 15:57 ` Antonio Ospite
2015-06-03 10:26 ` Tirdea, Irina
2015-06-03 20:49 ` Antonio Ospite
2015-06-05 16:34 ` Tirdea, Irina
2015-06-05 16:40 ` Dmitry Torokhov
2015-06-05 17:00 ` Tirdea, Irina
2015-06-05 17:11 ` Dmitry Torokhov
2015-06-05 17:34 ` Tirdea, Irina
2015-05-28 12:47 ` [PATCH 3/9] input: goodix: export id and version read from device Irina Tirdea
2015-05-28 12:47 ` [PATCH 4/9] input: goodix: add ACPI IDs for GT911 and GT9271 Irina Tirdea
2015-06-04 12:51 ` Bastien Nocera
2015-06-05 16:36 ` Tirdea, Irina
2015-06-05 16:41 ` Dmitry Torokhov
2015-06-05 17:01 ` Tirdea, Irina
2015-05-28 12:47 ` [PATCH 5/9] input: goodix: reset device at init Irina Tirdea
[not found] ` <1432817265-23891-6-git-send-email-irina.tirdea-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-05-28 13:19 ` Mark Rutland
2015-05-28 13:42 ` Tirdea, Irina
2015-05-28 12:47 ` [PATCH 6/9] input: goodix: write configuration data to device Irina Tirdea
2015-05-28 13:21 ` Mark Rutland [this message]
2015-05-28 13:51 ` Tirdea, Irina
2015-06-04 12:55 ` Bastien Nocera
2015-06-05 16:36 ` Tirdea, Irina
2015-06-05 16:43 ` Dmitry Torokhov
2015-06-05 17:05 ` Tirdea, Irina
2015-05-28 12:47 ` [PATCH 7/9] input: goodix: add power management support Irina Tirdea
2015-06-04 13:01 ` Bastien Nocera
2015-06-05 16:42 ` Tirdea, Irina
[not found] ` <1432817265-23891-1-git-send-email-irina.tirdea-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-05-28 12:47 ` [PATCH 8/9] input: goodix: add support for ESD Irina Tirdea
[not found] ` <1432817265-23891-9-git-send-email-irina.tirdea-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-05-28 13:23 ` Mark Rutland
2015-05-28 14:26 ` Tirdea, Irina
2015-06-04 12:57 ` Bastien Nocera
2015-06-05 16:37 ` Tirdea, Irina
2015-06-05 16:46 ` Dmitry Torokhov
2015-06-08 14:28 ` Tirdea, Irina
2015-07-30 12:06 ` Tirdea, Irina
2015-05-28 12:47 ` [PATCH 9/9] input: goodix: use goodix_i2c_write_u8 instead of i2c_master_send Irina Tirdea
2015-06-04 13:04 ` [PATCH 0/9] Goodix touchscreen enhancements Bastien Nocera
2015-06-05 16:36 ` Tirdea, Irina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150528132133.GI23176@leverpostej \
--to=mark.rutland@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hadess@hadess.net \
--cc=irina.tirdea@intel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=octavian.purdila@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).