From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Y Vo <yvo@apm.com>
Cc: linus.walleij@linaro.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-acpi@vger.kernel.org, Phong Vo <pvo@apm.com>,
Toan Le <toanle@apm.com>, Loc Ho <lho@apm.com>,
patches@apm.com
Subject: Re: [PATCH v0] gpio: xgene: add ACPI support for APM X-Gene GPIO standby driver
Date: Fri, 29 May 2015 12:25:01 +0300 [thread overview]
Message-ID: <20150529092501.GI1747@lahna.fi.intel.com> (raw)
In-Reply-To: <1432795588-17476-1-git-send-email-yvo@apm.com>
On Thu, May 28, 2015 at 01:46:28PM +0700, Y Vo wrote:
> +#ifdef CONFIG_ACPI
> + if (priv->nirq > 0) {
> + /* Register interrupt handlers for gpio signaled acpi events */
> + acpi_gpiochip_request_interrupts(&priv->bgc.gc);
> + }
> +#endif
You don't need to check CONFIG_ACPI as acpi_gpiochip_request_interrupts()
will be stubbed out if !CONFIG_ACPI.
Should you call acpi_gpiochip_free_interrupts() somewhere to unregister
the interrupts as well?
Even better if you can switch your driver to use GPIOLIB_IRQCHIP all
this is done automatically for you.
next prev parent reply other threads:[~2015-05-29 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 6:46 [PATCH v0] gpio: xgene: add ACPI support for APM X-Gene GPIO standby driver Y Vo
2015-05-29 9:25 ` Mika Westerberg [this message]
2015-05-29 9:42 ` Y Vo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150529092501.GI1747@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=lho@apm.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=patches@apm.com \
--cc=pvo@apm.com \
--cc=toanle@apm.com \
--cc=yvo@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).