From: Vinod Koul <vinod.koul@intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
Tony Lindgren <tony@atomide.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Linux MMC List <linux-mmc@vger.kernel.org>,
linux-crypto@vger.kernel.org,
linux-spi <linux-spi@vger.kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
ALSA Development Mailing List <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()
Date: Fri, 29 May 2015 15:48:46 +0530 [thread overview]
Message-ID: <20150529101846.GG3140@localhost> (raw)
In-Reply-To: <CAMuHMdVJ0h9qXxBWH9L2y4O2KLkEq12KW_6k8rTgi+Lux=C0gw@mail.gmail.com>
On Fri, May 29, 2015 at 11:42:27AM +0200, Geert Uytterhoeven wrote:
> On Fri, May 29, 2015 at 11:33 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> > On Tue, May 26, 2015 at 04:25:57PM +0300, Peter Ujfalusi wrote:
> >> dma_request_slave_channel_compat() 'eats' up the returned error codes which
> >> prevents drivers using the compat call to be able to do deferred probing.
> >>
> >> The new wrapper is identical in functionality but it will return with error
> >> code in case of failure and will pass the -EPROBE_DEFER to the caller in
> >> case dma_request_slave_channel_reason() returned with it.
> > This is okay but am worried about one more warpper, how about fixing
> > dma_request_slave_channel_compat()
>
> Then all callers of dma_request_slave_channel_compat() have to be
> modified to handle ERR_PTR first.
>
> The same is true for (the existing) dma_request_slave_channel_reason()
> vs. dma_request_slave_channel().
Good point, looking again, I think we should rather fix
dma_request_slave_channel_reason() as it was expected to return err code and
add new users. Anyway users of this API do expect the reason...
--
~Vinod
next prev parent reply other threads:[~2015-05-29 10:18 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 13:25 [PATCH 00/13] dmaengine + omap drivers: support fro deferred probing Peter Ujfalusi
2015-05-26 13:25 ` [PATCH 01/13] dmaengine: of_dma: Correct return code for of_dma_request_slave_channel in case !CONFIG_OF Peter Ujfalusi
2015-05-26 13:25 ` [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason() Peter Ujfalusi
2015-05-29 9:33 ` Vinod Koul
2015-05-29 9:42 ` Geert Uytterhoeven
2015-05-29 10:18 ` Vinod Koul [this message]
2015-05-29 14:32 ` Peter Ujfalusi
2015-06-02 12:55 ` Vinod Koul
2015-06-04 15:58 ` Peter Ujfalusi
2015-06-12 12:58 ` Vinod Koul
2015-06-22 11:31 ` Peter Ujfalusi
2015-06-24 16:24 ` Vinod Koul
2015-06-25 11:15 ` Arnd Bergmann
2015-11-18 14:21 ` Peter Ujfalusi
2015-11-18 14:29 ` Arnd Bergmann
2015-11-18 14:41 ` Peter Ujfalusi
2015-11-18 15:07 ` Arnd Bergmann
2015-11-18 15:43 ` Andy Shevchenko
[not found] ` <CAHp75VeZFXp9i_zz7CBkVQVPGQxuzYk9AbWbbbn33r8YX3LCdw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-11-18 15:51 ` Arnd Bergmann
2015-11-18 16:00 ` Andy Shevchenko
2015-11-18 16:06 ` Vinod Koul
2015-11-19 10:34 ` Peter Ujfalusi
2015-11-19 11:25 ` Arnd Bergmann
2015-11-20 10:25 ` Peter Ujfalusi
2015-11-20 10:58 ` Arnd Bergmann
2015-11-20 12:24 ` Andy Shevchenko
[not found] ` <CAHp75VdoHqPMNGFfz4mPhX+Lw+vxgiyqFS8j5+kQ9Z9CHt=OTA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-11-20 12:30 ` Peter Ujfalusi
[not found] ` <564F1253.4000800-l0cyMroinI0@public.gmane.org>
2015-11-20 14:08 ` Andy Shevchenko
2015-11-20 12:52 ` Peter Ujfalusi
[not found] ` <564F1773.9030006-l0cyMroinI0@public.gmane.org>
2015-11-20 13:48 ` Arnd Bergmann
2015-11-18 15:46 ` Andy Shevchenko
2015-11-19 10:36 ` Peter Ujfalusi
2015-05-26 13:25 ` [PATCH 04/13] mmc: omap_hsmmc: No need to check DMA channel validity at module remove Peter Ujfalusi
2015-05-28 7:20 ` Ulf Hansson
2015-05-26 13:26 ` [PATCH 05/13] mmc: omap_hsmmc: Support for deferred probing when requesting DMA channels Peter Ujfalusi
[not found] ` <1432646768-12532-6-git-send-email-peter.ujfalusi-l0cyMroinI0@public.gmane.org>
2015-05-28 7:23 ` Ulf Hansson
2015-05-26 13:26 ` [PATCH 06/13] mmc: omap: " Peter Ujfalusi
2015-05-26 13:26 ` [PATCH 07/13] mmc: davinci_mmc: " Peter Ujfalusi
2015-05-28 7:31 ` Ulf Hansson
2015-05-26 13:26 ` [PATCH 08/13] crypto: omap-aes - " Peter Ujfalusi
2015-05-26 13:26 ` [PATCH 10/13] crypto: omap-sham - Support for deferred probing when requesting DMA channel Peter Ujfalusi
2015-05-26 13:26 ` [PATCH 11/13] spi: omap2-mcspi: Support for deferred probing when requesting DMA channels Peter Ujfalusi
2015-05-26 15:27 ` Mark Brown
2015-05-27 11:15 ` Peter Ujfalusi
[not found] ` <5565A740.2020707-l0cyMroinI0@public.gmane.org>
2015-05-27 17:48 ` Mark Brown
2015-05-27 17:48 ` Mark Brown
2015-05-26 13:26 ` [PATCH 12/13] [media] omap3isp: Support for deferred probing when requesting DMA channel Peter Ujfalusi
2015-11-09 19:50 ` Laurent Pinchart
2015-11-10 7:56 ` Peter Ujfalusi
[not found] ` <1432646768-12532-1-git-send-email-peter.ujfalusi-l0cyMroinI0@public.gmane.org>
2015-05-26 13:25 ` [PATCH 03/13] serial: 8250_dma: Support for deferred probing when requesting DMA channels Peter Ujfalusi
[not found] ` <1432646768-12532-4-git-send-email-peter.ujfalusi-l0cyMroinI0@public.gmane.org>
2015-05-26 14:44 ` Greg Kroah-Hartman
2015-05-27 10:41 ` Peter Ujfalusi
2015-05-27 10:41 ` Peter Ujfalusi
2015-05-26 15:08 ` Tony Lindgren
2015-05-27 10:58 ` Peter Ujfalusi
2015-05-26 13:26 ` [PATCH 09/13] crypto: omap-des - " Peter Ujfalusi
2015-05-26 13:26 ` [PATCH 13/13] ASoC: omap-pcm: Switch to use dma_request_slave_channel_compat_reason() Peter Ujfalusi
2015-05-27 17:48 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150529101846.GG3140@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).