From: "Jakub Kiciński" <moorray3@wp.pl>
To: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
stefan@agner.ch, shawn.guo@linaro.org, kernel@pengutronix.de,
jslaby@suse.cz, linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
bhuvanchandra.dv@gmail.com
Subject: Re: [PATCH 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl
Date: Fri, 29 May 2015 12:04:21 +0200 [thread overview]
Message-ID: <20150529120421.754fd6ab@north> (raw)
In-Reply-To: <1432886754-30115-3-git-send-email-bhuvanchandra.dv@toradex.com>
On Fri, 29 May 2015 13:35:53 +0530, Bhuvanchandra DV wrote:
> The LPUART does not provide manual control of RTS/CTS signals,
> those can only be controlled by the hardware directly. Therefore
> manual control of those signals through mctrl can not be provided.
> The current implementation enables/disables the automatic control,
> which is not what mctrl should do, hence remove the incorrect
> implementation.
>
> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
Now that the functions do nothing there is probably no point in keeping
separate lpuart/lpuart32 variants.
next prev parent reply other threads:[~2015-05-29 10:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 8:05 [PATCH 0/3] Add RS-485 support and fix RTS/CTS implementation Bhuvanchandra DV
2015-05-29 8:05 ` [PATCH 1/3] ARM: dts: colibri-vf: Add pinmux for UART_0 aka UART_A RTS/CTS pins Bhuvanchandra DV
2015-05-29 8:05 ` [PATCH 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl Bhuvanchandra DV
2015-05-29 10:04 ` Jakub Kiciński [this message]
2015-05-29 10:10 ` Bhuvanchandra DV
2015-05-29 8:05 ` [PATCH 3/3] tty: serial: fsl_lpuart: Add support for RS-485 Bhuvanchandra DV
2015-05-29 10:18 ` Jakub Kiciński
2015-05-29 10:42 ` Bhuvanchandra DV
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150529120421.754fd6ab@north \
--to=moorray3@wp.pl \
--cc=bhuvanchandra.dv@gmail.com \
--cc=bhuvanchandra.dv@toradex.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).