From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 4/4] mfd: 88pm800: allocate pdata->rtc if not allocated earlier Date: Mon, 1 Jun 2015 09:22:00 +0100 Message-ID: <20150601082200.GC3329@x1> References: <1432937962-4537-1-git-send-email-vaibhav.hiremath@linaro.org> <1432937962-4537-5-git-send-email-vaibhav.hiremath@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1432937962-4537-5-git-send-email-vaibhav.hiremath@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Vaibhav Hiremath Cc: linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, sameo@linux.intel.com, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, Chao Xie List-Id: devicetree@vger.kernel.org On Sat, 30 May 2015, Vaibhav Hiremath wrote: > RTC in pmic 88PM800 can run even the core is powered off, and user > can set alarm in RTC. When the alarm is timed out, the PMIC will powe= r up > the core, and the whole system will boot up. And during PMIC driver p= robe, > it will read some register to find out whether this boot is caused by= RTC > timeout or not, and pass on this information to the RTC driver. >=20 > So we need rtc platform data to be existed in PMIC driver to pass thi= s > information. >=20 > Signed-off-by: Chao Xie > Signed-off-by: Vaibhav Hiremath > --- > drivers/mfd/88pm800.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) >=20 > diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c > index 8ea4467..34546a1 100644 > --- a/drivers/mfd/88pm800.c > +++ b/drivers/mfd/88pm800.c > @@ -586,6 +586,25 @@ static int pm800_probe(struct i2c_client *client= , > return ret; > } > =20 > + /* > + * RTC in pmic can run even the core is powered off, and user can s= et > + * alarm in RTC. When the alarm is time out, the PMIC will power up > + * the core, and the whole system will boot up. When PMIC driver is > + * probed, it will read out some register to find out whether this > + * boot is caused by RTC timeout or not, and it need pass this > + * information to RTC driver. > + * So we need rtc platform data to be existed to pass this informat= ion. > + */ > + if (!pdata->rtc) { > + pdata->rtc =3D devm_kzalloc(&client->dev, > + sizeof(*(pdata->rtc)), GFP_KERNEL); > + if (!pdata->rtc) { > + dev_err(&client->dev, > + "failed to allocate memory for rtc\n"); > + return -ENOMEM; > + } > + } > + Where is this memory first used? > ret =3D pm80x_init(client); > if (ret) { > dev_err(&client->dev, "pm800_init fail\n"); --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog