Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

Maxime Ripard
2015-06-01T09:22:49Z

[-- Attachment #1: Type: text/plain, Size: 489 bytes --]

On Sun, May 31, 2015 at 06:10:25PM +0200, Hans de Goede wrote:
> + /* We either want both gpio pins or neither (when in host mode) */
> + if (!data->id_det_gpio != !data->vbus_det_gpio) {
> + dev_err(dev, "failed to get id or vbus detect pin\n");
> + return -ENODEV;
> + }

The fact that the driver expects both to be set if one is should be in
the binding documentation.

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering