Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

Hans de Goede
2015-06-01T09:28:23Z

Hi,

On 01-06-15 11:22, Maxime Ripard wrote:
> On Sun, May 31, 2015 at 06:10:25PM +0200, Hans de Goede wrote:
>> + /* We either want both gpio pins or neither (when in host mode) */
>> + if (!data->id_det_gpio != !data->vbus_det_gpio) {
>> + dev_err(dev, "failed to get id or vbus detect pin\n");
>> + return -ENODEV;
>> + }
>
> The fact that the driver expects both to be set if one is should be in
> the binding documentation.

That would be behavior description, and I've always been told that the
binding should only document the hardware description, not the behavior.

Also this may change in the future as we add support for more boards,
e.g. the cubieboard seems to be unable to turn vbus off ever, so vbus-det
will always read as 1 / high, making it rather useless. This is something
which I still need to figure out how to deal with.

Regards,

Hans