From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH 2/3] edac: Add L3/SoC support to the APM X-Gene SoC EDAC driver Date: Mon, 1 Jun 2015 20:31:14 +0200 Message-ID: <20150601183114.GE10169@pd.tnic> References: <1432937075-16558-1-git-send-email-lho@apm.com> <1432937075-16558-2-git-send-email-lho@apm.com> <1432937075-16558-3-git-send-email-lho@apm.com> <1979546.jtvJnZomID@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Loc Ho Cc: Arnd Bergmann , Doug Thompson , Mauro Carvalho Chehab , Rob Herring , Mark Rutland , Ian Campbell , linux-edac-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Jon Masters , "patches-qTEPVZfXA3Y@public.gmane.org" List-Id: devicetree@vger.kernel.org On Mon, Jun 01, 2015 at 10:46:55AM -0700, Loc Ho wrote: > You are right... Let me just prints the error code instead. Anyone who > care will have to do post processing. Don't forget about the usability of the driver. If a user has to go open manuals when an error happens, you could just as well report naked register values and have a tool decode them. And this strategy (mcelog) turned out to be a real PITA, IMO. > Future or existent next generation may re-define them. You could easily have a strings array of per-family or per-soc error descriptions. For an example, take a look at drivers/edac/mce_amd.c which decodes MCEs on all relevant AMD machines. This is much more user-friendly than dumping register values which most people have no idea of where to start looking (and they don't really need to). HTH. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html