From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH v5 1/2] Renesas Ethernet AVB driver proper
Date: Mon, 08 Jun 2015 15:19:54 -0700 (PDT)
Message-ID: <20150608.151954.191885697349673611.davem@davemloft.net>
References: <1752433.KgeJV8aUGv@wasted.cogentembedded.com>
	<20150603.201204.761049104805679684.davem@davemloft.net>
	<55760CB0.1020503@cogentembedded.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Return-path: <linux-sh-owner@vger.kernel.org>
In-Reply-To: <55760CB0.1020503@cogentembedded.com>
Sender: linux-sh-owner@vger.kernel.org
To: sergei.shtylyov@cogentembedded.com
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, devicetree@vger.kernel.org, galak@codeaurora.org, netdev@vger.kernel.org, richardcochran@gmail.com, linux-sh@vger.kernel.org, mitsuhiro.kimura.kc@renesas.com
List-Id: devicetree@vger.kernel.org

From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Tue, 09 Jun 2015 00:44:16 +0300

> On 06/04/2015 06:12 AM, David Miller wrote:
> 
>> Furthermore, you should pass the NAPI context into ravb_rx() and use
> 
>    I guess I should have one NAPI context per RX queue?

Yes.

> 
>> it so that you can invoke napi_gro_receive() on all of the packets and
>> therefore support GRO.
> 
>    Hmm, I don't think I have a hardware support for generic RX offload...
> I'm still unsure what it is anyway -- is it used for IP packet
> defragmentation?

It's completely implemented in software, you don't need to do anything
other than properly invoke napi_gro_receive().