From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH v0] gpio_keys: fix gpio key driver to proper support GIC interrupt Date: Mon, 8 Jun 2015 08:30:52 +0200 Message-ID: <20150608063052.GW18985@pengutronix.de> References: <1433402712-21399-1-git-send-email-yvo@apm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1433402712-21399-1-git-send-email-yvo-qTEPVZfXA3Y@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Y Vo Cc: linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Dmitry Torokhov , linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Feng Kan , Phong Vo , patches-qTEPVZfXA3Y@public.gmane.org, Loc Ho , Toan Le List-Id: devicetree@vger.kernel.org Hello, On Thu, Jun 04, 2015 at 02:25:12PM +0700, Y Vo wrote: > GIC is designed to support two of trigger mechanisms - active level > high or edge rising. But in the gpio_keys driver, it tries to use bot= h > edge rising and edge falling trigger. This patch fixes the gpio_keys > driver to request only the edge rising event when failed to configure= the > interrupt. Is it possible to fix that in the GIC driver? I.e. let it switch the trigger direction to falling when it fired for raising? This would require to read out the current level, not sure this is possible?! Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig = | Industrial Linux Solutions | http://www.pengutronix.de/= | -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html