From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
Cc: gregkh@linuxfoundation.org, devicetree@vger.kernel.org,
linux-serial@vger.kernel.org, moorray3@wp.pl,
linux-kernel@vger.kernel.org, stefan@agner.ch,
bhuvanchandra.dv@gmail.com, kernel@pengutronix.de,
shawn.guo@linaro.org, jslaby@suse.cz,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl
Date: Mon, 8 Jun 2015 10:12:44 +0100 [thread overview]
Message-ID: <20150608091244.GS7557@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1433136067-20644-3-git-send-email-bhuvanchandra.dv@toradex.com>
On Mon, Jun 01, 2015 at 10:51:06AM +0530, Bhuvanchandra DV wrote:
> + /*
> + * CTS/RTS can _only_ be handled
> + * automatically by the hardware.
> + */
That's really not acceptable. You need to do something here so that you
can _force_ RTS to be deasserted when the kernel buffers fill up - be
that by stopping reading characters and letting the FIFO fill up or
something of that ilk.
Ignoring the rest of the flow control system in the kernel is not really
acceptable.
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-06-08 9:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 5:21 [PATCH V2 0/3] Add RS-485 support and fix RTS/CTS implementation Bhuvanchandra DV
2015-06-01 5:21 ` [PATCH V2 3/3] tty: serial: fsl_lpuart: Add support for RS-485 Bhuvanchandra DV
[not found] ` <1433136067-20644-1-git-send-email-bhuvanchandra.dv-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
2015-06-01 5:21 ` [PATCH V2 1/3] ARM: dts: colibri-vf: Add pinmux for UART_0 aka UART_A RTS/CTS pins Bhuvanchandra DV
2015-06-01 5:21 ` [PATCH V2 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl Bhuvanchandra DV
[not found] ` <1433136067-20644-3-git-send-email-bhuvanchandra.dv-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
2015-06-08 6:41 ` Uwe Kleine-König
2015-06-08 7:25 ` Bhuvanchandra DV
[not found] ` <20150608064113.GX18985-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-06-08 9:14 ` Russell King - ARM Linux
2015-06-08 9:19 ` Russell King - ARM Linux
2015-06-08 9:12 ` Russell King - ARM Linux [this message]
[not found] ` <20150608091244.GS7557-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2015-06-09 4:12 ` Bhuvanchandra DV
2015-06-08 5:58 ` [PATCH V2 0/3] Add RS-485 support and fix RTS/CTS implementation Bhuvanchandra DV
[not found] ` <55752EF5.1040103-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
2015-06-13 0:35 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150608091244.GS7557@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=bhuvanchandra.dv@gmail.com \
--cc=bhuvanchandra.dv@toradex.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=moorray3@wp.pl \
--cc=shawn.guo@linaro.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).