From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 2/8] mfd: axp20x: Add a cell for the usb power_supply part of the axp20x PMICs Date: Wed, 10 Jun 2015 08:35:14 +0100 Message-ID: <20150610073514.GW2982@x1> References: <1433885881-19809-1-git-send-email-hdegoede@redhat.com> <1433885881-19809-3-git-send-email-hdegoede@redhat.com> Reply-To: lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <1433885881-19809-3-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Hans de Goede Cc: Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Kishon Vijay Abraham I , Felipe Balbi , Maxime Ripard , Bruno =?iso-8859-1?Q?Pr=E9mont?= , linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, 09 Jun 2015, Hans de Goede wrote: > Add a cell for the usb power_supply part of the axp20x PMICs. >=20 > Note that this cell is only for the usb power_supply part and not the > ac-power / battery-charger / rtc-backup-bat-charger bits. >=20 > Depending on the board each of those must be enabled / disabled separatel= y > in devicetree as most boards do not use all 4. So in dt each one needs it= s > own child-node of the axp20x node. Another reason for using separate chil= d > nodes for each is so that other devicetree nodes can have a power-supply > property with a phandle referencing a node representing a single > power-supply. >=20 > The decision to use a separate devicetree node for each is reflected on > the kernel side by each getting its own mfd-cell / platform_device and > platform-driver. >=20 > Cc: Bruno Pr=C3=A9mont > Signed-off-by: Hans de Goede > --- > drivers/mfd/axp20x.c | 32 +++++++++++++++++++++++++++++++- > 1 file changed, 31 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > index 6ffbc11..47ce233 100644 > --- a/drivers/mfd/axp20x.c > +++ b/drivers/mfd/axp20x.c > @@ -113,6 +113,30 @@ static struct resource axp20x_pek_resources[] =3D { > }, > }; > =20 > +static struct resource axp20x_usb_power_supply_resources[] =3D { > + { > + .name =3D "VBUS_PLUGIN", > + .start =3D AXP20X_IRQ_VBUS_PLUGIN, > + .end =3D AXP20X_IRQ_VBUS_PLUGIN, > + .flags =3D IORESOURCE_IRQ, > + }, { > + .name =3D "VBUS_REMOVAL", > + .start =3D AXP20X_IRQ_VBUS_REMOVAL, > + .end =3D AXP20X_IRQ_VBUS_REMOVAL, > + .flags =3D IORESOURCE_IRQ, > + }, { > + .name =3D "VBUS_VALID", > + .start =3D AXP20X_IRQ_VBUS_VALID, > + .end =3D AXP20X_IRQ_VBUS_VALID, > + .flags =3D IORESOURCE_IRQ, > + }, { > + .name =3D "VBUS_NOT_VALID", > + .start =3D AXP20X_IRQ_VBUS_NOT_VALID, > + .end =3D AXP20X_IRQ_VBUS_NOT_VALID, > + .flags =3D IORESOURCE_IRQ, > + }, > +}; Can you take a look at the DEFINE_RES_* macros in include/linux/ioport.h please? > static struct resource axp22x_pek_resources[] =3D { > { > .name =3D "PEK_DBR", > @@ -165,7 +189,7 @@ static const struct regmap_config axp20x_regmap_confi= g =3D { > .val_bits =3D 8, > .wr_table =3D &axp20x_writeable_table, > .volatile_table =3D &axp20x_volatile_table, > - .max_register =3D AXP20X_FG_RES, > + .max_register =3D AXP20X_OCV(15), > .cache_type =3D REGCACHE_RBTREE, > }; > =20 > @@ -368,6 +392,12 @@ static struct mfd_cell axp20x_cells[] =3D { > .resources =3D axp20x_pek_resources, > }, { > .name =3D "axp20x-regulator", > + }, { > + .name =3D "axp20x-usb-power-supply", > + .of_compatible =3D "x-powers,axp202-usb-power-supply", > + .num_resources =3D > + ARRAY_SIZE(axp20x_usb_power_supply_resources), This wrap is only necessary due to the extreme tabbing used to line up the '=3D'. Please do something about that instead. > + .resources =3D axp20x_usb_power_supply_resources, > }, > }; > =20 --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.