Re: [PATCH v5 1/2] ARM: dts: vfxxx: Add OCOTP and OCROM nodes

[Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2261 bytes --]

Hi,

On Mon, Jun 08, 2015 at 10:07:53AM +0530, maitysanchayan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> > > Add a device tree node for the On-Chip One Time Programmable
> > > Controller (OCOTP) and the On-Chip ROM.
> > > 
> > > Signed-off-by: Sanchayan Maity <maitysanchayan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > > ---
> > >  arch/arm/boot/dts/vfxxx.dtsi | 12 ++++++++++++
> > >  1 file changed, 12 insertions(+)
> > > 
> > > diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
> > > index 2f4b04d..ed9b6b8 100644
> > > --- a/arch/arm/boot/dts/vfxxx.dtsi
> > > +++ b/arch/arm/boot/dts/vfxxx.dtsi
> > > @@ -56,6 +56,13 @@
> > >  		compatible = "simple-bus";
> > >  		interrupt-parent = <&mscm_ir>;
> > >  		ranges;
> > > +		ocotp-cfg = <&ocotp 0x410 0x420>;
> > > +		rom-revision = <&ocrom 0x80>;
> > > +
> > > +		ocrom: ocrom {
> > > +			compatible = "fsl,vf610-ocrom", "syscon";
> > > +			reg = <0x00000000 0x18000>;
> > > +		};
> > 
> > Shouldn't that use the new nvmem framework currently being discussed,
> > instead of defining custom bindings?
> 
> I am aware of those nvmem framework patches by Srinivas, however from what
> I can see that framework has not been merged yet atleast from the mail
> chain that I see for v5 of the patchset so I have not properly looked into
> that. Mark Brown did apply the regmap patches to his tree, but has the rest
> of the framework been merged or is it expected to be merged?

Yeah, obviously the plan is to get it merged, and there's some effort
toward that, with the amount of review that seem to slow down, so I
guess it's closer to its merge than to its first submission.

> If it is expected to be merged and if that framework is a fit for what we
> are trying to do here and it seems so on a quick glance, then I can go with
> that. However I still did like to hear from Arnd or have some more comments
> before I go for that approach with the next respin.

If it doesn't fit, don't hesitate to mention your concern on the
thread. What you're trying to do should definitely be covered by that
framework.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]