From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH v2 1/2] ARM: at91: dts: add isi & ov2640 dt nodes for at91sam9m10g45ek board Date: Thu, 18 Jun 2015 17:45:37 +0200 Message-ID: <20150618154537.GM27492@piout.net> References: <1434449315-9243-1-git-send-email-josh.wu@atmel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1434449315-9243-1-git-send-email-josh.wu-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Josh Wu Cc: Nicolas Ferre , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russell King , Pawel Moll , Ian Campbell , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Kumar Gala , Jean-Christophe Plagniol-Villard , Andrew Victor List-Id: devicetree@vger.kernel.org Hi, Seems good to me, a small comment below: On 16/06/2015 at 18:08:34 +0800, Josh Wu wrote : > @@ -1068,8 +1076,12 @@ > clocks = <&isi_clk>; > clock-names = "isi_clk"; > pinctrl-names = "default"; > - pinctrl-0 = <&pinctrl_isi>; > + pinctrl-0 = <&pinctrl_isi_data_0_7>; I would say that the pinctrl is board specific so both pinctrl-names and pinctrl-0 should go to at91sam9m10g45ek.dts -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html