From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 8/8] dt: cpufreq: st: Provide bindings for ST's CPUFreq implementation Date: Tue, 23 Jun 2015 09:59:06 +0100 Message-ID: <20150623085906.GI3245@x1> References: <1434987837-24212-1-git-send-email-lee.jones@linaro.org> <1434987837-24212-9-git-send-email-lee.jones@linaro.org> <20150623023458.GC16776@linux> <20150623070651.GA3245@x1> <20150623075509.GF16776@linux> <20150623083856.GH3245@x1> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-pm-owner@vger.kernel.org To: Javier Martinez Canillas Cc: Viresh Kumar , Rob Herring , kernel@stlinux.com, "linux-pm@vger.kernel.org" , "Rafael J. Wysocki" , Linux Kernel , "devicetree@vger.kernel.org" , ajitpal.singh@st.com, "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On Tue, 23 Jun 2015, Javier Martinez Canillas wrote: > Hello Lee and Viresh, >=20 > On Tue, Jun 23, 2015 at 10:38 AM, Lee Jones wr= ote: > > On Tue, 23 Jun 2015, Viresh Kumar wrote: > >> On 23-06-15, 08:06, Lee Jones wrote: > >> > > >> > > Over that, this patch should have been present before any othe= r > >> > > patches using these bindings. > >> > > >> > I've never heard that one before, but it's easy to re-order the = set. > >> > >> I don't know, but it seems obvious to me: Bindings first and then = the > >> code. > > > > Do you always write your documentation before implementing a > > feature? > > > > Surely it goes; > > Requirements Gathering > > Plan and Prepare > > Implement > > Test > > Document > > Deliver > > > > ;) > > > > ... but as I say, I can re-order if required. It's really not a pr= oblem. > > >=20 > This is actually documented in > Documentation/devicetree/bindings/submitting-patches.txt: > ... >=20 > 3) The Documentation/ portion of the patch should come in the serie= s before > the code implementing the binding. >=20 > .... >=20 > The rationale AFAIU is that it is easier to review the implementation > of a binding after reading the DT binding doc since then you can see > if the code matches what the DT binding describes. =46air enough. Can't argue with that. :) --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog