Re: [PATCH 2/2] power_supply: Add support for TI BQ25890 charger chip

[Pavel Machek <pavel@ucw.cz>]

On Wed 2015-06-24 10:32:54, Laurentiu Palcu wrote:
> On Sat, May 02, 2015 at 04:59:34PM +0200, Pavel Machek wrote:
> > 
> > Should this link....
> > 
> > > More details about the chip can be found here:
> > > http://www.ti.com/product/bq25890
> > 
> > > @@ -0,0 +1,998 @@
> > > +/*
> > > + * TI BQ25890 charger driver
> > > + *
> > > + * Copyright (C) 2015 Intel Corporation
> > > + *
> > > + * This program is free software; you can redistribute it and/or modify
> > > + * it under the terms of the GNU General Public License as published by
> > > + * the Free Software Foundation; either version 2 of the License, or
> > > + * (at your option) any later version.
> > > + *
> > > + * This program is distributed in the hope that it will be useful,
> > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > + * GNU General Public License for more details.
> > 
> > > + *
> > > + */
> > 
> > Go here?
> Where exactly? Was 'here' supposed to be a hyperlink that, for some
> reason, is missing? Anyway, if you're asking why the link I provided


Put the link to the comment at top of the driver, not into the
changelog.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html