From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 1/4] mfd: da9150: Add support for Fuel-Gauge Date: Thu, 25 Jun 2015 15:55:35 +0100 Message-ID: <20150625145535.GD23990@x1> References: <8d8f583fee9313f261efa96a038874e552995c17.1434643491.git.Adam.Thomson.Opensource@diasemi.com> <1434732461.2385.162.camel@x220> <2E89032DDAA8B9408CB92943514A0337AB555F28@SW-EX-MBX01.diasemi.com> <20150622111624.GF19061@x1> <2E89032DDAA8B9408CB92943514A0337AB557CA1@SW-EX-MBX01.diasemi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <2E89032DDAA8B9408CB92943514A0337AB557CA1-68WUHU125fLLPO1uwJ3ImwLouzNaz+3S@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Opensource [Adam Thomson]" Cc: Paul Bolle , Samuel Ortiz , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Support Opensource List-Id: devicetree@vger.kernel.org On Thu, 25 Jun 2015, Opensource [Adam Thomson] wrote: > On June 22, 2015 17:48, Lee Jones wrote: >=20 > > > > The pedant in me noticed that this function is actually added i= n 3/4. So > > > > this chunk might be moved to 3/4, if you like to entertain peda= ntry like > > > > that, that is. (But see my remark on 3/4 too.) > > > > > > This is true, but as the header is part of MFD, I included it as = part of that > > > patch as I thought this made more sense. I guess Lee will comment= as to whether > > > that was correct or not. :) > >=20 > > Glanced over this (as I still have 240 unread emails to attend to). > > If the question is whether to submit the prototype at the same time= as > > the associated function, the answer is yes. >=20 > Hope you've managed to trawl through the e-mails. >=20 > The question was whether or not the function and prototype should be = submitted > as part of the same individual patch file. Both are submitted as part= of the > patch set but the prototype resides in the MFD patch, and the functio= n in the > power (fuel-gauge) patch. Personally, this seems fine to me but I'm n= ot a > maintainer. Please move the prototype into the same patch that introduced the funct= ion. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html