From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yi Zhang <yizhang@marvell.com>
Subject: Re: [PATCH V2 1/2] mfd: add Marvell 88pm88x description
Date: Fri, 26 Jun 2015 11:35:25 +0800
Message-ID: <20150626033338.GA32229@yizhang>
References: <1434098601-3498-1-git-send-email-yizhang@marvell.com>
 <1434098601-3498-2-git-send-email-yizhang@marvell.com>
 <CAL_JsqKjNdtp1A7LqqnjAnGPmCu-fwum6D9EPOoaVF0C=DacTw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <CAL_JsqKjNdtp1A7LqqnjAnGPmCu-fwum6D9EPOoaVF0C=DacTw@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Rob Herring <robherring2@gmail.com>
Cc: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>, Samuel Ortiz <sameo@linux.intel.com>, Lee Jones <lee.jones@linaro.org>, Paul Bolle <pebolle@tiscali.nl>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Qiao Zhou <zhouqiao@marvell.com>
List-Id: devicetree@vger.kernel.org

On Tue, Jun 23, 2015 at 09:31:00AM -0500, Rob Herring wrote:
> On Fri, Jun 12, 2015 at 3:43 AM, Yi Zhang <yizhang@marvell.com> wrote:
> > 88pm880 and 88pm886 are two combo PMIC chips, most of the function and the
> > register mapping are the same
> 
> How do they compare to 80x/822/860 PMICs?

Hi, Rob:

88pm80x/822/860 and 88pm886/88pm880 are two different series:
- the register mapping is totally different, it's hard to reuse the
  existed code for 88pm80x
- the latter is a chip which integrates the charger/fuelgauge/camera
  flash which doesn't exist in 88pm80x
> 
> >
> > Signed-off-by: Yi Zhang <yizhang@marvell.com>
> > ---
> >  Documentation/devicetree/bindings/mfd/88pm88x.txt | 33 +++++++++++++++++++++++
> >  1 file changed, 33 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mfd/88pm88x.txt
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/88pm88x.txt b/Documentation/devicetree/bindings/mfd/88pm88x.txt
> > new file mode 100644
> > index 0000000..72e741c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/88pm88x.txt
> > @@ -0,0 +1,33 @@
> > +Marvell 88pm88x combo PMIC chip
> > +
> > +This series of chip integrates regulator, rtc, onkey, switch charger,
> > +fuelgauge, gpadc and a range of I/O pins.
> > +
> > +88pm886 and 88pm880 are two very similar chips, most of the registers mapping
> > +and functions are the same, the main difference is the latter has a separate
> > +i2c slave address to cover BUCK related setting
> > +
> > +Required properties:
> > +- compatible: one of the strings for a specific chip:
> > +  "marvell,88pm886"
> > +  "marvell,88pm880"
> > +- reg: the i2c address
> > +- interrupt-controller: it works as an interrupt controller managing its irqs
> > +- interrupt-cells: this value is 1
> > +
> > +Optional properties:
> > +- marvell,88pm88x-irq-write-clear: the interrupt ack method
> 
> The 80x/860 binding needs the same property. Please coordinate this
> with Vaibhav.

  Thanks for your reminder, got it
> 
> Rob