From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
To: Mark Brown <broonie@kernel.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH] mmc: core: Set load on vmmc and vqmmc
Date: Thu, 2 Jul 2015 11:10:36 -0700 [thread overview]
Message-ID: <20150702181036.GF9633@sonymobile.com> (raw)
In-Reply-To: <20150701105925.GT11162@sirena.org.uk>
On Wed 01 Jul 03:59 PDT 2015, Mark Brown wrote:
> On Tue, Jun 30, 2015 at 09:38:45PM -0700, Bjorn Andersson wrote:
>
> > +- vmmc-load: requested load for the vmmc regulator, in mA
> > +- vqmmc-load: requested load for the vqmmc regulator, in mA
>
> Isn't this something that should have default values from the spec? The
> binding also ought to say what a "requested load" is.
It sounds reasonable that these values should simply come from the card
specification; I don't know if there's any sane way for us to list them
though (other than just stating them in dt).
I'll have to do some more investigation on the subject...
And I get your point that it's not "requested load", it's the power
requirements of the card...so it should be rephrased.
Thanks,
Bjorn
next prev parent reply other threads:[~2015-07-02 18:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 4:38 [PATCH] mmc: core: Set load on vmmc and vqmmc Bjorn Andersson
2015-07-01 10:59 ` Mark Brown
2015-07-02 18:10 ` Bjorn Andersson [this message]
2015-10-13 1:00 ` [PATCH v2] mmc: core: Allow specifying current consumption Bjorn Andersson
2015-10-16 12:55 ` Ulf Hansson
[not found] ` <CAPDyKFqQEY64AToR0So72Sc4DtKhH5Sxff=oy8pDZZmw8O0aMQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-17 17:09 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150702181036.GF9633@sonymobile.com \
--to=bjorn.andersson@sonymobile.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).