From: Pavel Machek <pavel@ucw.cz>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Sebastian Reichel <sre@kernel.org>,
Tony Lindgren <tony@atomide.com>,
Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: rx51-battery.ko incompatiblity: board code vs DT
Date: Tue, 7 Jul 2015 12:41:50 +0200 [thread overview]
Message-ID: <20150707104150.GC13811@amd> (raw)
In-Reply-To: <201507062144.22911@pali>
On Mon 2015-07-06 21:44:22, Pali Rohár wrote:
> Hello,
>
> now I found out that rx51-battery.ko driver register sysnode
> /sys/class/power_supply/rx51-battery/ when booting with legacy board
> code. But when booting DT kernel it register sysnode with different name
> /sys/class/power_supply/n900-battery/
>
> Sysfs node for DT kernel comes from Nokia N900 DTS file:
> arch/arm/boot/dts/omap3-n900.dts
>
> I would propose change which change DTS to "rx51-battery" to have it
> compatible with naming which is for legacy board code. It is just
> because to have compatibility and same naming scheme and also to make
> existing programs to work without needing patching them.
>
> What do you think?
Makes sense.. along with _big_ comment in the dts why we are doing
this.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-07-07 10:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 19:44 rx51-battery.ko incompatiblity: board code vs DT Pali Rohár
2015-07-07 10:41 ` Pavel Machek [this message]
2015-07-07 15:02 ` Sebastian Reichel
2015-07-07 15:15 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150707104150.GC13811@amd \
--to=pavel@ucw.cz \
--cc=aaro.koskinen@iki.fi \
--cc=devicetree@vger.kernel.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).