From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH-V5 3/4] mfd: 88pm800: Set default interrupt clear method Date: Tue, 7 Jul 2015 15:57:56 +0100 Message-ID: <20150707145756.GJ3182@x1> References: <1435591877-18214-4-git-send-email-vaibhav.hiremath@linaro.org> <20150707072958.GN3182@x1> <559BA1AE.9050006@linaro.org> <20150707104028.GR3182@x1> <559BAF23.90002@linaro.org> <20150707111248.GU3182@x1> <559BB58E.9010406@linaro.org> <559BB727.2070106@linaro.org> <20150707125439.GE3182@x1> <559BE68B.3020801@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <559BE68B.3020801@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Vaibhav Hiremath Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, robh+dt@kernel.org, sameo@linux.intel.com, linux-kernel@vger.kernel.org, yizhang@marvell.com, Zhao Ye List-Id: devicetree@vger.kernel.org On Tue, 07 Jul 2015, Vaibhav Hiremath wrote: >=20 >=20 > On Tuesday 07 July 2015 06:24 PM, Lee Jones wrote: > >On Tue, 07 Jul 2015, Vaibhav Hiremath wrote: > > > >> > >> > >>On Tuesday 07 July 2015 04:48 PM, Vaibhav Hiremath wrote: > >>> > >>> > >>>On Tuesday 07 July 2015 04:42 PM, Lee Jones wrote: > >>>>On Tue, 07 Jul 2015, Vaibhav Hiremath wrote: > >>>>>On Tuesday 07 July 2015 04:10 PM, Lee Jones wrote: > >>>>>>On Tue, 07 Jul 2015, Vaibhav Hiremath wrote: > >>>>>>>On Tuesday 07 July 2015 12:59 PM, Lee Jones wrote: > >>>>>>>>On Mon, 29 Jun 2015, Vaibhav Hiremath wrote: > >>>>>>>> > >>>>>>>>>As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe > >>>>>>>>>(page 0) controls the method of clearing interrupt > >>>>>>>>>status of 88pm800 family of devices; > >>>>>>>>> > >>>>>>>>> 0: clear on read > >>>>>>>>> 1: clear on write > >>>>>>>>> > >>>>>>>>>If pdata is not coming from board file, then set the > >>>>>>>>>default irq clear method to "irq clear on write" > >>>>>>>>> > >>>>>>>>>Also, as suggested by "Lee Jones" renaming variable field > >>>>>>>>>to appropriate name. > >>>>>>>>> > >>>>>>>>>Signed-off-by: Zhao Ye > >>>>>>>>>Signed-off-by: Vaibhav Hiremath > >>>>>>>>>--- > >>>>>>>>> drivers/mfd/88pm800.c | 15 ++++++++++----- > >>>>>>>>> include/linux/mfd/88pm80x.h | 10 ++++++++-- > >>>>>>>>> 2 files changed, 18 insertions(+), 7 deletions(-) > >>>>>>>>> >=20 > >=20 > >>> > >>>Yes certainly, this is another option (rather preferred one). > >>> > >>>But to be consistent with other's I proposed this, please refer to= the > >>>fn device_800_init(), where all xxx_init() are taking 2 arguments,= and > >>>second argument is pdata. > >>> > >>> > >>>There is room for cleanup, I agree. > >>>I can put this too in the next cleanup series. > >>> > >> > >>Note that this is init function, called from probe. > >> > >>So both approach looks ok to me. > > > >Please clean up the other. Function and put it at the front of the > >set when you re-submit. > > >=20 > Sorry for dumb question here :) > I did not understand what do you mean by "in front of the set"? >=20 > You want to see all the patches into one single series? > Or > have separate series, > 1. existing DT addition series > 2. new clean-up series [PATCH v6 0/5] mfd: 88pm800: Add Device tree support =E2=94=9C>[PATCH v6 1/5] mfd: 88pm800: Obtain pdata from 'device' rathe= r than passing as parameter =E2=94=9C>[PATCH v6 2/5] mfd: 88pm800: Add device tree support =E2=94=9C>[PATCH v6 3/5] mfd: 88pm800: Remove unnecessary protection ar= ound pdata =E2=94=9C>[PATCH v6 4/5] mfd: 88pm800: Set default interrupt clear meth= od =E2=94=9C>[PATCH v6 5/5] mfd: devicetree: bindings: Add new 88pm800 mfd= binding --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog