rx51-battery.ko incompatiblity: board code vs DT

rx51-battery.ko incompatiblity: board code vs DT

[Pali Rohár]

[-- Attachment #1: Type: Text/Plain, Size: 688 bytes --]

Hello,

now I found out that rx51-battery.ko driver register sysnode 
/sys/class/power_supply/rx51-battery/ when booting with legacy board 
code. But when booting DT kernel it register sysnode with different name 
/sys/class/power_supply/n900-battery/

Sysfs node for DT kernel comes from Nokia N900 DTS file: 
arch/arm/boot/dts/omap3-n900.dts

I would propose change which change DTS to "rx51-battery" to have it 
compatible with naming which is for legacy board code. It is just 
because to have compatibility and same naming scheme and also to make 
existing programs to work without needing patching them.

What do you think?

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: rx51-battery.ko incompatiblity: board code vs DT

[Pavel Machek]

On Mon 2015-07-06 21:44:22, Pali Rohár wrote:
> Hello,
> 
> now I found out that rx51-battery.ko driver register sysnode 
> /sys/class/power_supply/rx51-battery/ when booting with legacy board 
> code. But when booting DT kernel it register sysnode with different name 
> /sys/class/power_supply/n900-battery/
> 
> Sysfs node for DT kernel comes from Nokia N900 DTS file: 
> arch/arm/boot/dts/omap3-n900.dts
> 
> I would propose change which change DTS to "rx51-battery" to have it 
> compatible with naming which is for legacy board code. It is just 
> because to have compatibility and same naming scheme and also to make 
> existing programs to work without needing patching them.
> 
> What do you think?

Makes sense.. along with _big_ comment in the dts why we are doing
this.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: rx51-battery.ko incompatiblity: board code vs DT

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 979 bytes --]

Hi,

On Mon, Jul 06, 2015 at 09:44:22PM +0200, Pali Rohár wrote:
> now I found out that rx51-battery.ko driver register sysnode 
> /sys/class/power_supply/rx51-battery/ when booting with legacy board 
> code. But when booting DT kernel it register sysnode with different name 
> /sys/class/power_supply/n900-battery/
> 
> Sysfs node for DT kernel comes from Nokia N900 DTS file: 
> arch/arm/boot/dts/omap3-n900.dts
> 
> I would propose change which change DTS to "rx51-battery" to have it 
> compatible with naming which is for legacy board code. It is just 
> because to have compatibility and same naming scheme and also to make 
> existing programs to work without needing patching them.
> 
> What do you think?

Change the driver instead (in rx51_battery_probe):

-   di->bat.name = dev_name(&pdev->dev);
+   di->bat.name = "rx51-battery"

This will keep the DT ABI stable and avoid introducing the term rx51
in the device tree file.

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: rx51-battery.ko incompatiblity: board code vs DT

[Pali Rohár]

On Tuesday 07 July 2015 17:02:30 Sebastian Reichel wrote:
> Hi,
> 
> On Mon, Jul 06, 2015 at 09:44:22PM +0200, Pali Rohár wrote:
> > now I found out that rx51-battery.ko driver register sysnode 
> > /sys/class/power_supply/rx51-battery/ when booting with legacy board 
> > code. But when booting DT kernel it register sysnode with different name 
> > /sys/class/power_supply/n900-battery/
> > 
> > Sysfs node for DT kernel comes from Nokia N900 DTS file: 
> > arch/arm/boot/dts/omap3-n900.dts
> > 
> > I would propose change which change DTS to "rx51-battery" to have it 
> > compatible with naming which is for legacy board code. It is just 
> > because to have compatibility and same naming scheme and also to make 
> > existing programs to work without needing patching them.
> > 
> > What do you think?
> 
> Change the driver instead (in rx51_battery_probe):
> 
> -   di->bat.name = dev_name(&pdev->dev);
> +   di->bat.name = "rx51-battery"
> 
> This will keep the DT ABI stable and avoid introducing the term rx51
> in the device tree file.
> 
> -- Sebastian

Perfect, if it works fine can you send & apply patch?

-- 
Pali Rohár
pali.rohar@gmail.com