From: Tony Lindgren <tony@atomide.com>
To: Andreas Fenkart <afenkart@gmail.com>
Cc: devicetree@vger.kernel.org, linux-mmc@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH] Documentation: dt: update ti,am33xx-hsmmc swakeup workaround
Date: Tue, 7 Jul 2015 23:33:39 -0700 [thread overview]
Message-ID: <20150708063339.GH10644@atomide.com> (raw)
In-Reply-To: <1436291591-31271-1-git-send-email-afenkart@gmail.com>
* Andreas Fenkart <afenkart@gmail.com> [150707 10:55]:
> Before 5b83b2234be6733cf the driver was hard coding the wakeup irq to
> be active low. The generic pm wakeirq does not override the active
> high/low parameter, hence it must be specified correctly in the
> device tree.
> Mind that SDIO IRQ is active low as defined in the SDIO specification
>
> Signed-off-by: Andreas Fenkart <afenkart@gmail.com>
> ---
> Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
> index 76bf087..74166a0 100644
> --- a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
> +++ b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
> @@ -102,7 +102,7 @@ not every application needs SDIO irq, e.g. MMC cards.
> pinctrl-1 = <&mmc1_idle>;
> pinctrl-2 = <&mmc1_sleep>;
> ...
> - interrupts-extended = <&intc 64 &gpio2 28 0>;
> + interrupts-extended = <&intc 64 &gpio2 28 GPIO_ACTIVE_LOW>;
> };
>
> mmc1_idle : pinmux_cirq_pin {
Looks good to me:
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2015-07-08 6:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 17:53 [PATCH] Documentation: dt: update ti,am33xx-hsmmc swakeup workaround Andreas Fenkart
2015-07-08 6:33 ` Tony Lindgren [this message]
2015-07-21 11:11 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150708063339.GH10644@atomide.com \
--to=tony@atomide.com \
--cc=afenkart@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).