* [PATCH] Documentation: dt: update ti,am33xx-hsmmc swakeup workaround
@ 2015-07-07 17:53 Andreas Fenkart
2015-07-08 6:33 ` Tony Lindgren
2015-07-21 11:11 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Andreas Fenkart @ 2015-07-07 17:53 UTC (permalink / raw)
To: devicetree; +Cc: linux-mmc, Ulf Hansson, Tony Lindgren, Andreas Fenkart
Before 5b83b2234be6733cf the driver was hard coding the wakeup irq to
be active low. The generic pm wakeirq does not override the active
high/low parameter, hence it must be specified correctly in the
device tree.
Mind that SDIO IRQ is active low as defined in the SDIO specification
Signed-off-by: Andreas Fenkart <afenkart@gmail.com>
---
Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
index 76bf087..74166a0 100644
--- a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
+++ b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
@@ -102,7 +102,7 @@ not every application needs SDIO irq, e.g. MMC cards.
pinctrl-1 = <&mmc1_idle>;
pinctrl-2 = <&mmc1_sleep>;
...
- interrupts-extended = <&intc 64 &gpio2 28 0>;
+ interrupts-extended = <&intc 64 &gpio2 28 GPIO_ACTIVE_LOW>;
};
mmc1_idle : pinmux_cirq_pin {
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Documentation: dt: update ti,am33xx-hsmmc swakeup workaround
2015-07-07 17:53 [PATCH] Documentation: dt: update ti,am33xx-hsmmc swakeup workaround Andreas Fenkart
@ 2015-07-08 6:33 ` Tony Lindgren
2015-07-21 11:11 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2015-07-08 6:33 UTC (permalink / raw)
To: Andreas Fenkart; +Cc: devicetree, linux-mmc, Ulf Hansson
* Andreas Fenkart <afenkart@gmail.com> [150707 10:55]:
> Before 5b83b2234be6733cf the driver was hard coding the wakeup irq to
> be active low. The generic pm wakeirq does not override the active
> high/low parameter, hence it must be specified correctly in the
> device tree.
> Mind that SDIO IRQ is active low as defined in the SDIO specification
>
> Signed-off-by: Andreas Fenkart <afenkart@gmail.com>
> ---
> Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
> index 76bf087..74166a0 100644
> --- a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
> +++ b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
> @@ -102,7 +102,7 @@ not every application needs SDIO irq, e.g. MMC cards.
> pinctrl-1 = <&mmc1_idle>;
> pinctrl-2 = <&mmc1_sleep>;
> ...
> - interrupts-extended = <&intc 64 &gpio2 28 0>;
> + interrupts-extended = <&intc 64 &gpio2 28 GPIO_ACTIVE_LOW>;
> };
>
> mmc1_idle : pinmux_cirq_pin {
Looks good to me:
Acked-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Documentation: dt: update ti,am33xx-hsmmc swakeup workaround
2015-07-07 17:53 [PATCH] Documentation: dt: update ti,am33xx-hsmmc swakeup workaround Andreas Fenkart
2015-07-08 6:33 ` Tony Lindgren
@ 2015-07-21 11:11 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2015-07-21 11:11 UTC (permalink / raw)
To: Andreas Fenkart; +Cc: devicetree@vger.kernel.org, linux-mmc, Tony Lindgren
On 7 July 2015 at 19:53, Andreas Fenkart <afenkart@gmail.com> wrote:
> Before 5b83b2234be6733cf the driver was hard coding the wakeup irq to
> be active low. The generic pm wakeirq does not override the active
> high/low parameter, hence it must be specified correctly in the
> device tree.
> Mind that SDIO IRQ is active low as defined in the SDIO specification
>
> Signed-off-by: Andreas Fenkart <afenkart@gmail.com>
Thanks, applied!
Kind regards
Uffe
> ---
> Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
> index 76bf087..74166a0 100644
> --- a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
> +++ b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
> @@ -102,7 +102,7 @@ not every application needs SDIO irq, e.g. MMC cards.
> pinctrl-1 = <&mmc1_idle>;
> pinctrl-2 = <&mmc1_sleep>;
> ...
> - interrupts-extended = <&intc 64 &gpio2 28 0>;
> + interrupts-extended = <&intc 64 &gpio2 28 GPIO_ACTIVE_LOW>;
> };
>
> mmc1_idle : pinmux_cirq_pin {
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-21 11:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-07 17:53 [PATCH] Documentation: dt: update ti,am33xx-hsmmc swakeup workaround Andreas Fenkart
2015-07-08 6:33 ` Tony Lindgren
2015-07-21 11:11 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).