From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Dave Gerlach <d-gerlach-l0cyMroinI0@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jassi Brar
<jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Santosh Shilimkar
<ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Suman Anna <s-anna-l0cyMroinI0@public.gmane.org>,
Keerthy <j-keerthy-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH v2 3/3] soc: ti: Add wkup_m3_ipc driver
Date: Sun, 19 Jul 2015 23:16:00 -0700 [thread overview]
Message-ID: <20150720061559.GX17550@atomide.com> (raw)
In-Reply-To: <1437166592-25378-4-git-send-email-d-gerlach-l0cyMroinI0@public.gmane.org>
* Dave Gerlach <d-gerlach-l0cyMroinI0@public.gmane.org> [150717 13:59]:
> +
> +/* Public functions */
...
> +EXPORT_SYMBOL_GPL(wkup_m3_set_mem_type);
> +EXPORT_SYMBOL_GPL(wkup_m3_set_resume_address);
> +EXPORT_SYMBOL_GPL(wkup_m3_request_pm_status);
> +EXPORT_SYMBOL_GPL(wkup_m3_prepare_low_power);
> +EXPORT_SYMBOL_GPL(wkup_m3_finish_low_power);
I think you can avoid exporting these SoC specific functions
by just exporting wkup_m3_request() and wkup_m3_free() type
functions with a data structure containing the necessary
function pointers.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-07-20 6:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 20:56 [PATCH v2 0/3] soc: ti: Introduce wkup_m3_ipc driver Dave Gerlach
2015-07-17 20:56 ` [PATCH v2 1/3] mailbox/omap: Add ti,mbox-send-noirq quirk to fix AM33xx CPU Idle Dave Gerlach
2015-08-05 10:28 ` Tony Lindgren
2015-08-05 15:32 ` Suman Anna
[not found] ` <55C22C8E.3000506-l0cyMroinI0@public.gmane.org>
2015-08-06 6:29 ` Tony Lindgren
2015-07-17 20:56 ` [PATCH v2 2/3] Documentation: dt: add bindings for TI Wakeup M3 IPC device Dave Gerlach
2015-07-17 20:56 ` [PATCH v2 3/3] soc: ti: Add wkup_m3_ipc driver Dave Gerlach
[not found] ` <1437166592-25378-4-git-send-email-d-gerlach-l0cyMroinI0@public.gmane.org>
2015-07-20 6:16 ` Tony Lindgren [this message]
2015-08-04 20:58 ` Dave Gerlach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720061559.GX17550@atomide.com \
--to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
--cc=d-gerlach-l0cyMroinI0@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=j-keerthy-l0cyMroinI0@public.gmane.org \
--cc=jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=s-anna-l0cyMroinI0@public.gmane.org \
--cc=ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).