From: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Dudley Du <dudl-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org>
Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
rydberg-Hk7bIW8heu4wFerOooGFRg@public.gmane.org,
bleung-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
jmmahler-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v1 3/7] input: cyapa: add proximity function support for gen5 and gen6 modules
Date: Mon, 20 Jul 2015 17:06:58 -0700 [thread overview]
Message-ID: <20150721000658.GD15528@dtor-ws> (raw)
In-Reply-To: <1434358897-24668-4-git-send-email-dudl-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org>
Hi Dudley,
On Mon, Jun 15, 2015 at 05:01:33PM +0800, Dudley Du wrote:
>
> +static void cyapa_pip_report_proximity(struct cyapa *cyapa,
> + const struct cyapa_pip_report_data *report_data)
> +{
> + struct input_dev *input = cyapa->input;
> + u8 distance = report_data->report_head[PIP_PROXIMITY_DISTANCE_OFFSET] &
> + PIP_PROXIMITY_DISTANCE_MASK;
> +
> + input_report_abs(input, ABS_MT_DISTANCE, distance);
> + input_sync(input);
It looks like the distance reported by the hardware is not per-contact
(i.e. it can not tell that we had 2 fingers on surface and the 2nd one
was lifted and is now hovering over the surface), so we should be using
ABS_DISTANCE, not ABS_MT_DISTANCE.
I can adjust it here, no need to resend.
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-07-21 0:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 9:01 [PATCH v1 0/7] instruction of cyapa gen6 and proximity patches Dudley Du
2015-06-15 9:01 ` [PATCH v1 1/7] input: cyapa: change strings of gen5 to pip in the name when they are shared Dudley Du
[not found] ` <1434358897-24668-2-git-send-email-dudl-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org>
2015-07-21 0:03 ` Dmitry Torokhov
2015-06-15 9:01 ` [PATCH v1 2/7] input: cyapa: add gen6 device module support in driver Dudley Du
[not found] ` <1434358897-24668-3-git-send-email-dudl-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org>
2015-07-21 0:04 ` Dmitry Torokhov
[not found] ` <1434358897-24668-1-git-send-email-dudl-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org>
2015-06-15 9:01 ` [PATCH v1 3/7] input: cyapa: add proximity function support for gen5 and gen6 modules Dudley Du
[not found] ` <1434358897-24668-4-git-send-email-dudl-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org>
2015-07-21 0:06 ` Dmitry Torokhov [this message]
2015-07-21 1:43 ` Dudley Du
2015-06-15 9:01 ` [PATCH v1 4/7] input: cyapa: fully support runtime suspend power management Dudley Du
[not found] ` <1434358897-24668-5-git-send-email-dudl-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org>
2015-07-21 0:13 ` Dmitry Torokhov
2015-06-17 22:09 ` [PATCH v1 0/7] instruction of cyapa gen6 and proximity patches Jeremiah Mahler
2015-06-15 9:01 ` [PATCH v1 5/7] input: cyapa: add proximity and interrupt sysfs interfaces support Dudley Du
2015-06-15 9:01 ` [PATCH v1 6/7] input: cyapa: add of match device support and description document Dudley Du
2015-07-21 0:15 ` Dmitry Torokhov
2015-07-21 2:15 ` Dudley Du
2015-06-15 9:01 ` [PATCH v1 7/7] input: cyapa: add CYAP0002 Gen6 device for ACPI configuration Dudley Du
[not found] ` <1434358897-24668-8-git-send-email-dudl-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org>
2015-07-21 0:17 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150721000658.GD15528@dtor-ws \
--to=dmitry.torokhov-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=bleung-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dudl-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org \
--cc=jmmahler-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=rydberg-Hk7bIW8heu4wFerOooGFRg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).