Re: [PATCH v7 00/23] usb gadget update for OTG 2.0

[Li Jun <b47624-KZfg59tc24xl57MIdRCFDg@public.gmane.org>]

On Wed, Jul 22, 2015 at 10:13:08AM -0500, Felipe Balbi wrote:
> On Thu, Jul 09, 2015 at 03:18:37PM +0800, Li Jun wrote:
> > Change for v7:
> > - Free otg descriptor when failure of bind in patch 21, 22, 23.
> >   add Roger's Reviewed-by for patch 10~20.
> > - Choose the lesser otg-rev if otg-rev has been set before update by DT,
> >   remove 0x0300 in supported otg-rev list, and add code comments in case
> >   otg-rev is not passed in DT in patch 7.
> > - Fail chipidea usb initilization if DT pass an unsupported otg-rev in patch 8.
> > 
> > Change for v6:
> > - Change of_usb_set_otg_caps to be of_usb_update_otg_caps, and add
> >   sanity check of otg-rev.
> > - Add chipidea otg-rev ability to be 0x0200, which will be updated
> >   in DT, if not passed, will be reset to be 0.
> > - Remove unnecessary change: move config's descriptor and bmAttributes
> >   init from xxxi_config() to xxx_bind() in leagcy gadget drivers.
> > 
> > This is a follow-up of Macpaul Lin's previous patchset to resolve usb
> > gadget driver working with OTG 2.0, and set otg features by not only
> > usb driver config but also usb hardware property in DT, main changes:
> > 1. Add usb_otg20_descriptor definition for OTG 2.0 which introduces bcdOTG
> >    field for otg revision, bcdOTG can be passed via device tree.
> > 2. OTG features(SRP/HNP/ADP) can be decided by combination of usb HW
> >    properties and usb driver config.
> > 3. Change the chipidea usb driver to use the updated mechanism.
> > 4. Remove static usb otg descriptor definition, but allocate and init it
> >    according to otg capabilities in each gadget driver, if otg capabilities
> >    is not defined for legacy platforms, the usb otg descriptor content is
> >    kept the same as current static definition.
> > 
> > Li Jun (19):
> >   usb: otg: add usb_otg_caps structure for otg capabilities
> >   doc: dt-binding: usb: add otg related properties
> >   usb: common: add API to update usb otg capabilities by device tree
> >   usb: chipidea: set usb otg capabilities
> >   usb: chipidea: update ci_otg_is_fsm_mode conditions
> >   usb: gadget: add usb otg descriptor allocate and init interface
> >   usb: gadget: configfs: allocate and init otg descriptor by otg
> >     capabilities
> >   usb: gadget: ether: allocate and init otg descriptor by otg
> >     capabilities
> >   usb: gadget: acm_ms: allocate and init otg descriptor by otg
> >     capabilities
> >   usb: gadget: audio: allocate and init otg descriptor by otg
> >     capabilities
> >   usb: gadget: cdc2: allocate and init otg descriptor by otg
> >     capabilities
> >   usb: gadget: g_ffs: allocate and init otg descriptor by otg
> >     capabilities
> >   usb: gadget: hid: allocate and init otg descriptor by otg capabilities
> >   usb: gadget: mass_storage: allocate and init otg descriptor by otg
> >     capabilities
> >   usb: gadget: multi: allocate and init otg descriptor by otg
> >     capabilities
> >   usb: gadget: ncm: allocate and init otg descriptor by otg capabilities
> >   usb: gadget: printer: allocate and init otg descriptor by otg
> >     capabilities
> >   usb: gadget: serial: allocate and init otg descriptor by otg
> >     capabilities
> >   usb: gadget: zero: allocate and init otg descriptor by otg
> >     capabilities
> > 
> > Macpaul Lin (4):
> >   usb: add usb_otg20_descriptor for OTG 2.0 and above
> >   usb: add USB_OTG_ADP definition
> >   usb: add usb_otg_caps to usb_gadget structure.
> >   usb: gadget: composite: add USB_DT_OTG request handling
> 
> ok, so how you guys want to handle this series ? Should I take
> everything through my tree ? I'd need Acked-by for all chipidea drivers
> if that's the case.
> 
> -- 
> balbi

I will resend the whole series with a small fix and Peter's ACK for
chipidea part.

Li Jun


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html