From: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
To: Suneel Garapati <suneel.garapati@xilinx.com>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@vger.kernel.org,
michals@xilinx.com, sorenb@xilinx.com,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] devicetree: xilinx: add rtc node to zynqmp dtsi
Date: Thu, 23 Jul 2015 06:58:42 -0700 [thread overview]
Message-ID: <20150723135842.GG2531@xsjsorenbubuntu> (raw)
In-Reply-To: <1437648740-7587-1-git-send-email-suneel.garapati@xilinx.com>
Hi Suneel,
On Thu, 2015-07-23 at 04:22PM +0530, Suneel Garapati wrote:
> adds rtc controller node to zynqmp devicetree.
>
> Signed-off-by: Suneel Garapati <suneel.garapati@xilinx.com>
> ---
> arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts | 4 ++++
> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 9 +++++++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts b/arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts
> index 0a3f40e..b48ce47 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts
> @@ -45,3 +45,7 @@
> &uart0 {
> status = "okay";
> };
> +
> +&rtc {
> + status = "okay";
> +};
> \ No newline at end of file
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index 11e0b00..b76ede1 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -220,6 +220,15 @@
> #size-cells = <0>;
> };
>
> + rtc: rtc@ffa60000 {
> + compatible = "xlnx,zynqmp-rtc";
> + status = "disabled";
do we need the status disabled here?
> + reg = <0x0 0xffa60000 0x100>;
> + interrupt-parent = <&gic>;
> + interrupts = <0 26 4>, <0 27 4>;
> + interrupt-names = "alm", "sec";
Descriptive names would be nice. What is 'alm' supposed to mean?
Thanks,
Sören
prev parent reply other threads:[~2015-07-23 13:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 10:52 [PATCH] devicetree: xilinx: add rtc node to zynqmp dtsi Suneel Garapati
2015-07-23 13:58 ` Sören Brinkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150723135842.GG2531@xsjsorenbubuntu \
--to=soren.brinkmann@xilinx.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michals@xilinx.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sorenb@xilinx.com \
--cc=suneel.garapati@xilinx.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).