[PATCH v6 0/3] cpufreq: Use cpufreq-dt driver for Exynos3250

[PATCH v6 0/3] cpufreq: Use cpufreq-dt driver for Exynos3250

[Chanwoo Choi]

This patchset use cpufreq-dt driver to support Exynos3250 cpufreq and tested it
on Exynos3250-based Rinato board.

Depends on:
- next-20150701 tag (master branch) of linux-next kernel tree
- This patch-set is based on Exynos5250 patch-set[1] because two patch-set
  modify the 'arch/arm/mach-exynos/exynos.c' to add the compatible string.
  [1] https://lkml.org/lkml/2015/6/29/361
  : [PATCH v2 0/4] cpufreq: use generic cpufreq drivers for Exynos5250 platform

Changes from v5:
(https://lkml.org/lkml/2015/7/1/324)
- Reorder the cpu dt node in exynos3250-rinato/monk.dts alpabetically.
- Add reviewed-by tag of Krzysztof Kozlowski <k.kozlowski@samsung.com>

Changes from v4:
(https://lkml.org/lkml/2014/10/20/215)
- Rebased on latest linux-next git repository.
- Remove unnecessary divider clock flag from divider of DIV_CPU0/DIV_CPU1 register

Changes from v3:
- This patchset is based on 3.18-rc1 with new patchset[3] of Thomas Abraham
  [3] [PATCH v11 0/6] cpufreq: use generic cpufreq drivers for exynos platforms
  - http://www.spinics.net/lists/arm-kernel/msg370412.html

Changes from v2:
- Rebased on new patchset of Thomas Abraham
  and for-next branch of samsunc-clk.git of Tomasz Figa

Changes from v1:
- Rebased on new patchset[1] by Thomas Abraham
  [1] [PATCH v10 0/6] cpufreq: use generic cpufreq drivers for exynos platforms
  - http://www.spinics.net/lists/arm-kernel/msg364790.html
- Modify clk-cpu.c to support Exynos3250
- Drop documentation patch on previous patchset[2]
  [2] http://www.spinics.net/lists/cpufreq/msg10265.html
- Add only operating-points for Exynos3250 without armclk-divider-table

Chanwoo Choi (3):
  clk: samsung: exynos3250: Add cpu clock configuration data and instaniate cpu clock
  ARM: dts: Add CPU OPP and regulator supply property for Exynos3250
  ARM: exynos: Add exynos3250 compatible to use generic cpufreq driver

 arch/arm/boot/dts/exynos3250-monk.dts   |  4 ++++
 arch/arm/boot/dts/exynos3250-rinato.dts |  4 ++++
 arch/arm/boot/dts/exynos3250.dtsi       | 15 +++++++++++++++
 arch/arm/mach-exynos/exynos.c           |  1 +
 drivers/clk/samsung/clk-exynos3250.c    | 32 ++++++++++++++++++++++++++++++--
 include/dt-bindings/clock/exynos3250.h  |  1 +
 6 files changed, 55 insertions(+), 2 deletions(-)

-- 
1.8.5.5

[PATCH v6 1/3] clk: samsung: exynos3250: Add cpu clock configuration data and instaniate cpu clock

[Chanwoo Choi]

This patch add CPU clock configuration data and instantiate the CPU clock type
for Exynos3250 to support Samsung specific cpu-clock type.

Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Tomasz Figa <tomasz.figa@gmail.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
 drivers/clk/samsung/clk-exynos3250.c   | 32 ++++++++++++++++++++++++++++++--
 include/dt-bindings/clock/exynos3250.h |  1 +
 2 files changed, 31 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/samsung/clk-exynos3250.c b/drivers/clk/samsung/clk-exynos3250.c
index 538de66a759e..378ad5ad3492 100644
--- a/drivers/clk/samsung/clk-exynos3250.c
+++ b/drivers/clk/samsung/clk-exynos3250.c
@@ -19,6 +19,7 @@
 #include <dt-bindings/clock/exynos3250.h>
 
 #include "clk.h"
+#include "clk-cpu.h"
 #include "clk-pll.h"
 
 #define SRC_LEFTBUS		0x4200
@@ -319,8 +320,10 @@ static struct samsung_mux_clock mux_clks[] __initdata = {
 	MUX(CLK_MOUT_MPLL_USER_C, "mout_mpll_user_c", mout_mpll_user_p,
 	    SRC_CPU, 24, 1),
 	MUX(CLK_MOUT_HPM, "mout_hpm", mout_hpm_p, SRC_CPU, 20, 1),
-	MUX(CLK_MOUT_CORE, "mout_core", mout_core_p, SRC_CPU, 16, 1),
-	MUX(CLK_MOUT_APLL, "mout_apll", mout_apll_p, SRC_CPU, 0, 1),
+	MUX_F(CLK_MOUT_CORE, "mout_core", mout_core_p, SRC_CPU, 16, 1,
+			CLK_SET_RATE_PARENT, 0),
+	MUX_F(CLK_MOUT_APLL, "mout_apll", mout_apll_p, SRC_CPU, 0, 1,
+			CLK_SET_RATE_PARENT, 0),
 };
 
 static struct samsung_div_clock div_clks[] __initdata = {
@@ -772,6 +775,26 @@ static struct samsung_cmu_info cmu_info __initdata = {
 	.nr_clk_regs		= ARRAY_SIZE(exynos3250_cmu_clk_regs),
 };
 
+#define E3250_CPU_DIV0(apll, pclk_dbg, atb, corem)                     \
+               (((apll) << 24) | ((pclk_dbg) << 20) | ((atb) << 16) |  \
+               ((corem) << 4))
+#define E3250_CPU_DIV1(hpm, copy)					\
+		(((hpm) << 4) | ((copy) << 0))
+
+static const struct exynos_cpuclk_cfg_data e3250_armclk_d[] __initconst = {
+       { 1000000, E3250_CPU_DIV0(1, 7, 4, 1), E3250_CPU_DIV1(7, 7), },
+       {  900000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },
+       {  800000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },
+       {  700000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },
+       {  600000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },
+       {  500000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },
+       {  400000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },
+       {  300000, E3250_CPU_DIV0(1, 5, 3, 1), E3250_CPU_DIV1(7, 7), },
+       {  200000, E3250_CPU_DIV0(1, 3, 3, 1), E3250_CPU_DIV1(7, 7), },
+       {  100000, E3250_CPU_DIV0(1, 1, 1, 1), E3250_CPU_DIV1(7, 7), },
+       {  0 },
+};
+
 static void __init exynos3250_cmu_init(struct device_node *np)
 {
 	struct samsung_clk_provider *ctx;
@@ -780,6 +803,11 @@ static void __init exynos3250_cmu_init(struct device_node *np)
 	if (!ctx)
 		return;
 
+	exynos_register_cpu_clock(ctx, CLK_ARM_CLK, "armclk",
+			mout_core_p[0], mout_core_p[1], 0x14200,
+			e3250_armclk_d, ARRAY_SIZE(e3250_armclk_d),
+			CLK_CPU_HAS_DIV1);
+
 	exynos3_core_down_clock(ctx->reg_base);
 }
 CLK_OF_DECLARE(exynos3250_cmu, "samsung,exynos3250-cmu", exynos3250_cmu_init);
diff --git a/include/dt-bindings/clock/exynos3250.h b/include/dt-bindings/clock/exynos3250.h
index aab088d30199..63d01c15d2b3 100644
--- a/include/dt-bindings/clock/exynos3250.h
+++ b/include/dt-bindings/clock/exynos3250.h
@@ -31,6 +31,7 @@
 #define CLK_FOUT_VPLL			4
 #define CLK_FOUT_UPLL			5
 #define CLK_FOUT_MPLL			6
+#define CLK_ARM_CLK			7
 
 /* Muxes */
 #define CLK_MOUT_MPLL_USER_L		16
-- 
1.8.5.5

Re: [PATCH v6 1/3] clk: samsung: exynos3250: Add cpu clock configuration data and instaniate cpu clock

[Krzysztof Kozlowski]

2015-07-02 9:42 GMT+09:00 Chanwoo Choi <cw00.choi@samsung.com>:
> This patch add CPU clock configuration data and instantiate the CPU clock type
> for Exynos3250 to support Samsung specific cpu-clock type.
>
> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Cc: Tomasz Figa <tomasz.figa@gmail.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  drivers/clk/samsung/clk-exynos3250.c   | 32 ++++++++++++++++++++++++++++++--
>  include/dt-bindings/clock/exynos3250.h |  1 +

Sylwester,

I think this patch also waits for your review or ack.
The patchset is rebased on Bartlomiej's series for Exynos5250 cpufreq
so the easiest way would be to take it through samsung-soc tree.

Best regards,
Krzysztof


>  2 files changed, 31 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk-exynos3250.c b/drivers/clk/samsung/clk-exynos3250.c
> index 538de66a759e..378ad5ad3492 100644
> --- a/drivers/clk/samsung/clk-exynos3250.c
> +++ b/drivers/clk/samsung/clk-exynos3250.c
> @@ -19,6 +19,7 @@
>  #include <dt-bindings/clock/exynos3250.h>
>
>  #include "clk.h"
> +#include "clk-cpu.h"
>  #include "clk-pll.h"
>
>  #define SRC_LEFTBUS            0x4200
> @@ -319,8 +320,10 @@ static struct samsung_mux_clock mux_clks[] __initdata = {
>         MUX(CLK_MOUT_MPLL_USER_C, "mout_mpll_user_c", mout_mpll_user_p,
>             SRC_CPU, 24, 1),
>         MUX(CLK_MOUT_HPM, "mout_hpm", mout_hpm_p, SRC_CPU, 20, 1),
> -       MUX(CLK_MOUT_CORE, "mout_core", mout_core_p, SRC_CPU, 16, 1),
> -       MUX(CLK_MOUT_APLL, "mout_apll", mout_apll_p, SRC_CPU, 0, 1),
> +       MUX_F(CLK_MOUT_CORE, "mout_core", mout_core_p, SRC_CPU, 16, 1,
> +                       CLK_SET_RATE_PARENT, 0),
> +       MUX_F(CLK_MOUT_APLL, "mout_apll", mout_apll_p, SRC_CPU, 0, 1,
> +                       CLK_SET_RATE_PARENT, 0),
>  };
>
>  static struct samsung_div_clock div_clks[] __initdata = {
> @@ -772,6 +775,26 @@ static struct samsung_cmu_info cmu_info __initdata = {
>         .nr_clk_regs            = ARRAY_SIZE(exynos3250_cmu_clk_regs),
>  };
>
> +#define E3250_CPU_DIV0(apll, pclk_dbg, atb, corem)                     \
> +               (((apll) << 24) | ((pclk_dbg) << 20) | ((atb) << 16) |  \
> +               ((corem) << 4))
> +#define E3250_CPU_DIV1(hpm, copy)                                      \
> +               (((hpm) << 4) | ((copy) << 0))
> +
> +static const struct exynos_cpuclk_cfg_data e3250_armclk_d[] __initconst = {
> +       { 1000000, E3250_CPU_DIV0(1, 7, 4, 1), E3250_CPU_DIV1(7, 7), },
> +       {  900000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },
> +       {  800000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },
> +       {  700000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },
> +       {  600000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },
> +       {  500000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },
> +       {  400000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },
> +       {  300000, E3250_CPU_DIV0(1, 5, 3, 1), E3250_CPU_DIV1(7, 7), },
> +       {  200000, E3250_CPU_DIV0(1, 3, 3, 1), E3250_CPU_DIV1(7, 7), },
> +       {  100000, E3250_CPU_DIV0(1, 1, 1, 1), E3250_CPU_DIV1(7, 7), },
> +       {  0 },
> +};
> +
>  static void __init exynos3250_cmu_init(struct device_node *np)
>  {
>         struct samsung_clk_provider *ctx;
> @@ -780,6 +803,11 @@ static void __init exynos3250_cmu_init(struct device_node *np)
>         if (!ctx)
>                 return;
>
> +       exynos_register_cpu_clock(ctx, CLK_ARM_CLK, "armclk",
> +                       mout_core_p[0], mout_core_p[1], 0x14200,
> +                       e3250_armclk_d, ARRAY_SIZE(e3250_armclk_d),
> +                       CLK_CPU_HAS_DIV1);
> +
>         exynos3_core_down_clock(ctx->reg_base);
>  }
>  CLK_OF_DECLARE(exynos3250_cmu, "samsung,exynos3250-cmu", exynos3250_cmu_init);
> diff --git a/include/dt-bindings/clock/exynos3250.h b/include/dt-bindings/clock/exynos3250.h
> index aab088d30199..63d01c15d2b3 100644
> --- a/include/dt-bindings/clock/exynos3250.h
> +++ b/include/dt-bindings/clock/exynos3250.h
> @@ -31,6 +31,7 @@
>  #define CLK_FOUT_VPLL                  4
>  #define CLK_FOUT_UPLL                  5
>  #define CLK_FOUT_MPLL                  6
> +#define CLK_ARM_CLK                    7
>
>  /* Muxes */
>  #define CLK_MOUT_MPLL_USER_L           16
> --
> 1.8.5.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v6 1/3] clk: samsung: exynos3250: Add cpu clock configuration data and instaniate cpu clock

[Chanwoo Choi]

Hi Sylwester,

Please review this patch.

Best Regards,
Chanwoo Choi

On 07/16/2015 04:46 PM, Krzysztof Kozlowski wrote:
> 2015-07-02 9:42 GMT+09:00 Chanwoo Choi <cw00.choi@samsung.com>:
>> This patch add CPU clock configuration data and instantiate the CPU clock type
>> for Exynos3250 to support Samsung specific cpu-clock type.
>>
>> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
>> Cc: Tomasz Figa <tomasz.figa@gmail.com>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> ---
>>  drivers/clk/samsung/clk-exynos3250.c   | 32 ++++++++++++++++++++++++++++++--
>>  include/dt-bindings/clock/exynos3250.h |  1 +
> 
> Sylwester,
> 
> I think this patch also waits for your review or ack.
> The patchset is rebased on Bartlomiej's series for Exynos5250 cpufreq
> so the easiest way would be to take it through samsung-soc tree.
> 
> Best regards,
> Krzysztof
> 
> 
>>  2 files changed, 31 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/clk/samsung/clk-exynos3250.c b/drivers/clk/samsung/clk-exynos3250.c
>> index 538de66a759e..378ad5ad3492 100644
>> --- a/drivers/clk/samsung/clk-exynos3250.c
>> +++ b/drivers/clk/samsung/clk-exynos3250.c
>> @@ -19,6 +19,7 @@
>>  #include <dt-bindings/clock/exynos3250.h>
>>
>>  #include "clk.h"
>> +#include "clk-cpu.h"
>>  #include "clk-pll.h"
>>
>>  #define SRC_LEFTBUS            0x4200
>> @@ -319,8 +320,10 @@ static struct samsung_mux_clock mux_clks[] __initdata = {
>>         MUX(CLK_MOUT_MPLL_USER_C, "mout_mpll_user_c", mout_mpll_user_p,
>>             SRC_CPU, 24, 1),
>>         MUX(CLK_MOUT_HPM, "mout_hpm", mout_hpm_p, SRC_CPU, 20, 1),
>> -       MUX(CLK_MOUT_CORE, "mout_core", mout_core_p, SRC_CPU, 16, 1),
>> -       MUX(CLK_MOUT_APLL, "mout_apll", mout_apll_p, SRC_CPU, 0, 1),
>> +       MUX_F(CLK_MOUT_CORE, "mout_core", mout_core_p, SRC_CPU, 16, 1,
>> +                       CLK_SET_RATE_PARENT, 0),
>> +       MUX_F(CLK_MOUT_APLL, "mout_apll", mout_apll_p, SRC_CPU, 0, 1,
>> +                       CLK_SET_RATE_PARENT, 0),
>>  };
>>
>>  static struct samsung_div_clock div_clks[] __initdata = {
>> @@ -772,6 +775,26 @@ static struct samsung_cmu_info cmu_info __initdata = {
>>         .nr_clk_regs            = ARRAY_SIZE(exynos3250_cmu_clk_regs),
>>  };
>>
>> +#define E3250_CPU_DIV0(apll, pclk_dbg, atb, corem)                     \
>> +               (((apll) << 24) | ((pclk_dbg) << 20) | ((atb) << 16) |  \
>> +               ((corem) << 4))
>> +#define E3250_CPU_DIV1(hpm, copy)                                      \
>> +               (((hpm) << 4) | ((copy) << 0))
>> +
>> +static const struct exynos_cpuclk_cfg_data e3250_armclk_d[] __initconst = {
>> +       { 1000000, E3250_CPU_DIV0(1, 7, 4, 1), E3250_CPU_DIV1(7, 7), },
>> +       {  900000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },
>> +       {  800000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },
>> +       {  700000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },
>> +       {  600000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },
>> +       {  500000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },
>> +       {  400000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },
>> +       {  300000, E3250_CPU_DIV0(1, 5, 3, 1), E3250_CPU_DIV1(7, 7), },
>> +       {  200000, E3250_CPU_DIV0(1, 3, 3, 1), E3250_CPU_DIV1(7, 7), },
>> +       {  100000, E3250_CPU_DIV0(1, 1, 1, 1), E3250_CPU_DIV1(7, 7), },
>> +       {  0 },
>> +};
>> +
>>  static void __init exynos3250_cmu_init(struct device_node *np)
>>  {
>>         struct samsung_clk_provider *ctx;
>> @@ -780,6 +803,11 @@ static void __init exynos3250_cmu_init(struct device_node *np)
>>         if (!ctx)
>>                 return;
>>
>> +       exynos_register_cpu_clock(ctx, CLK_ARM_CLK, "armclk",
>> +                       mout_core_p[0], mout_core_p[1], 0x14200,
>> +                       e3250_armclk_d, ARRAY_SIZE(e3250_armclk_d),
>> +                       CLK_CPU_HAS_DIV1);
>> +
>>         exynos3_core_down_clock(ctx->reg_base);
>>  }
>>  CLK_OF_DECLARE(exynos3250_cmu, "samsung,exynos3250-cmu", exynos3250_cmu_init);
>> diff --git a/include/dt-bindings/clock/exynos3250.h b/include/dt-bindings/clock/exynos3250.h
>> index aab088d30199..63d01c15d2b3 100644
>> --- a/include/dt-bindings/clock/exynos3250.h
>> +++ b/include/dt-bindings/clock/exynos3250.h
>> @@ -31,6 +31,7 @@
>>  #define CLK_FOUT_VPLL                  4
>>  #define CLK_FOUT_UPLL                  5
>>  #define CLK_FOUT_MPLL                  6
>> +#define CLK_ARM_CLK                    7
>>
>>  /* Muxes */
>>  #define CLK_MOUT_MPLL_USER_L           16
>> --
>> 1.8.5.5
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH v6 1/3] clk: samsung: exynos3250: Add cpu clock configuration data and instaniate cpu clock

[Kukjin Kim]

On 07/20/15 09:23, Chanwoo Choi wrote:
> Hi Sylwester,
> 
Hi Chanwoo,

> Please review this patch.
> 
Applied with Mike's ack BTW please make sure your patch has no problem
with checkpatch before submitting....I've fixed them when I applied.

Thanks,
Kukjin

ERROR: code indent should use tabs where possible
#49: FILE: drivers/clk/samsung/clk-exynos3250.c:779:
+               (((apll) << 24) | ((pclk_dbg) << 20) | ((atb) << 16) |  \$

WARNING: please, no spaces at the start of a line
#49: FILE: drivers/clk/samsung/clk-exynos3250.c:779:
+               (((apll) << 24) | ((pclk_dbg) << 20) | ((atb) << 16) |  \$

ERROR: code indent should use tabs where possible
#50: FILE: drivers/clk/samsung/clk-exynos3250.c:780:
+               ((corem) << 4))$

WARNING: please, no spaces at the start of a line
#50: FILE: drivers/clk/samsung/clk-exynos3250.c:780:
+               ((corem) << 4))$

WARNING: please, no spaces at the start of a line
#55: FILE: drivers/clk/samsung/clk-exynos3250.c:785:
+       { 1000000, E3250_CPU_DIV0(1, 7, 4, 1), E3250_CPU_DIV1(7, 7), },$

WARNING: please, no spaces at the start of a line
#56: FILE: drivers/clk/samsung/clk-exynos3250.c:786:
+       {  900000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },$

WARNING: please, no spaces at the start of a line
#57: FILE: drivers/clk/samsung/clk-exynos3250.c:787:
+       {  800000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },$

WARNING: please, no spaces at the start of a line
#58: FILE: drivers/clk/samsung/clk-exynos3250.c:788:
+       {  700000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },$

WARNING: please, no spaces at the start of a line
#59: FILE: drivers/clk/samsung/clk-exynos3250.c:789:
+       {  600000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },$

WARNING: please, no spaces at the start of a line
#60: FILE: drivers/clk/samsung/clk-exynos3250.c:790:
+       {  500000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },$

WARNING: please, no spaces at the start of a line
#61: FILE: drivers/clk/samsung/clk-exynos3250.c:791:
+       {  400000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },$

WARNING: please, no spaces at the start of a line
#62: FILE: drivers/clk/samsung/clk-exynos3250.c:792:
+       {  300000, E3250_CPU_DIV0(1, 5, 3, 1), E3250_CPU_DIV1(7, 7), },$

WARNING: please, no spaces at the start of a line
#63: FILE: drivers/clk/samsung/clk-exynos3250.c:793:
+       {  200000, E3250_CPU_DIV0(1, 3, 3, 1), E3250_CPU_DIV1(7, 7), },$

WARNING: please, no spaces at the start of a line
#64: FILE: drivers/clk/samsung/clk-exynos3250.c:794:
+       {  100000, E3250_CPU_DIV0(1, 1, 1, 1), E3250_CPU_DIV1(7, 7), },$

WARNING: please, no spaces at the start of a line
#65: FILE: drivers/clk/samsung/clk-exynos3250.c:795:
+       {  0 },$

total: 2 errors, 13 warnings, 63 lines checked

NOTE: Whitespace errors detected.
      You may wish to use scripts/cleanpatch or scripts/cleanfile

[PATCH v6 1_3] clk: samsung: exynos3250: Add cpu clock configuration
data and instaniate cpu clock.eml has style problems, please review.


> Best Regards,
> Chanwoo Choi
> 
> On 07/16/2015 04:46 PM, Krzysztof Kozlowski wrote:
>> 2015-07-02 9:42 GMT+09:00 Chanwoo Choi <cw00.choi@samsung.com>:
>>> This patch add CPU clock configuration data and instantiate the CPU clock type
>>> for Exynos3250 to support Samsung specific cpu-clock type.
>>>
>>> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
>>> Cc: Tomasz Figa <tomasz.figa@gmail.com>
>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>>> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
>>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>> ---
>>>  drivers/clk/samsung/clk-exynos3250.c   | 32 ++++++++++++++++++++++++++++++--
>>>  include/dt-bindings/clock/exynos3250.h |  1 +
>>
>> Sylwester,
>>
>> I think this patch also waits for your review or ack.
>> The patchset is rebased on Bartlomiej's series for Exynos5250 cpufreq
>> so the easiest way would be to take it through samsung-soc tree.
>>
>> Best regards,
>> Krzysztof
>>
>>
>>>  2 files changed, 31 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/clk/samsung/clk-exynos3250.c b/drivers/clk/samsung/clk-exynos3250.c
>>> index 538de66a759e..378ad5ad3492 100644
>>> --- a/drivers/clk/samsung/clk-exynos3250.c
>>> +++ b/drivers/clk/samsung/clk-exynos3250.c
>>> @@ -19,6 +19,7 @@
>>>  #include <dt-bindings/clock/exynos3250.h>
>>>
>>>  #include "clk.h"
>>> +#include "clk-cpu.h"
>>>  #include "clk-pll.h"
>>>
>>>  #define SRC_LEFTBUS            0x4200
>>> @@ -319,8 +320,10 @@ static struct samsung_mux_clock mux_clks[] __initdata = {
>>>         MUX(CLK_MOUT_MPLL_USER_C, "mout_mpll_user_c", mout_mpll_user_p,
>>>             SRC_CPU, 24, 1),
>>>         MUX(CLK_MOUT_HPM, "mout_hpm", mout_hpm_p, SRC_CPU, 20, 1),
>>> -       MUX(CLK_MOUT_CORE, "mout_core", mout_core_p, SRC_CPU, 16, 1),
>>> -       MUX(CLK_MOUT_APLL, "mout_apll", mout_apll_p, SRC_CPU, 0, 1),
>>> +       MUX_F(CLK_MOUT_CORE, "mout_core", mout_core_p, SRC_CPU, 16, 1,
>>> +                       CLK_SET_RATE_PARENT, 0),
>>> +       MUX_F(CLK_MOUT_APLL, "mout_apll", mout_apll_p, SRC_CPU, 0, 1,
>>> +                       CLK_SET_RATE_PARENT, 0),
>>>  };
>>>
>>>  static struct samsung_div_clock div_clks[] __initdata = {
>>> @@ -772,6 +775,26 @@ static struct samsung_cmu_info cmu_info __initdata = {
>>>         .nr_clk_regs            = ARRAY_SIZE(exynos3250_cmu_clk_regs),
>>>  };
>>>
>>> +#define E3250_CPU_DIV0(apll, pclk_dbg, atb, corem)                     \
>>> +               (((apll) << 24) | ((pclk_dbg) << 20) | ((atb) << 16) |  \
>>> +               ((corem) << 4))
>>> +#define E3250_CPU_DIV1(hpm, copy)                                      \
>>> +               (((hpm) << 4) | ((copy) << 0))
>>> +
>>> +static const struct exynos_cpuclk_cfg_data e3250_armclk_d[] __initconst = {
>>> +       { 1000000, E3250_CPU_DIV0(1, 7, 4, 1), E3250_CPU_DIV1(7, 7), },
>>> +       {  900000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },
>>> +       {  800000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },
>>> +       {  700000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },
>>> +       {  600000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },
>>> +       {  500000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },
>>> +       {  400000, E3250_CPU_DIV0(1, 7, 3, 1), E3250_CPU_DIV1(7, 7), },
>>> +       {  300000, E3250_CPU_DIV0(1, 5, 3, 1), E3250_CPU_DIV1(7, 7), },
>>> +       {  200000, E3250_CPU_DIV0(1, 3, 3, 1), E3250_CPU_DIV1(7, 7), },
>>> +       {  100000, E3250_CPU_DIV0(1, 1, 1, 1), E3250_CPU_DIV1(7, 7), },
>>> +       {  0 },
>>> +};
>>> +
>>>  static void __init exynos3250_cmu_init(struct device_node *np)
>>>  {
>>>         struct samsung_clk_provider *ctx;
>>> @@ -780,6 +803,11 @@ static void __init exynos3250_cmu_init(struct device_node *np)
>>>         if (!ctx)
>>>                 return;
>>>
>>> +       exynos_register_cpu_clock(ctx, CLK_ARM_CLK, "armclk",
>>> +                       mout_core_p[0], mout_core_p[1], 0x14200,
>>> +                       e3250_armclk_d, ARRAY_SIZE(e3250_armclk_d),
>>> +                       CLK_CPU_HAS_DIV1);
>>> +
>>>         exynos3_core_down_clock(ctx->reg_base);
>>>  }
>>>  CLK_OF_DECLARE(exynos3250_cmu, "samsung,exynos3250-cmu", exynos3250_cmu_init);
>>> diff --git a/include/dt-bindings/clock/exynos3250.h b/include/dt-bindings/clock/exynos3250.h
>>> index aab088d30199..63d01c15d2b3 100644
>>> --- a/include/dt-bindings/clock/exynos3250.h
>>> +++ b/include/dt-bindings/clock/exynos3250.h
>>> @@ -31,6 +31,7 @@
>>>  #define CLK_FOUT_VPLL                  4
>>>  #define CLK_FOUT_UPLL                  5
>>>  #define CLK_FOUT_MPLL                  6
>>> +#define CLK_ARM_CLK                    7
>>>
>>>  /* Muxes */
>>>  #define CLK_MOUT_MPLL_USER_L           16
>>> --

[PATCH v6 2/3] ARM: dts: Add CPU OPP and regulator supply property for Exynos3250

[Chanwoo Choi]

This patch add CPU operating points which include CPU frequency and regulator
voltage to use generic cpufreq drivers.

Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
 arch/arm/boot/dts/exynos3250-monk.dts   |  4 ++++
 arch/arm/boot/dts/exynos3250-rinato.dts |  4 ++++
 arch/arm/boot/dts/exynos3250.dtsi       | 15 +++++++++++++++
 3 files changed, 23 insertions(+)

diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts
index a5863acc5fff..7863265d4868 100644
--- a/arch/arm/boot/dts/exynos3250-monk.dts
+++ b/arch/arm/boot/dts/exynos3250-monk.dts
@@ -141,6 +141,10 @@
 	};
 };
 
+&cpu0 {
+	cpu0-supply = <&buck2_reg>;
+};
+
 &exynos_usbphy {
 	status = "okay";
 };
diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
index 031853b75528..ddd7ac283045 100644
--- a/arch/arm/boot/dts/exynos3250-rinato.dts
+++ b/arch/arm/boot/dts/exynos3250-rinato.dts
@@ -132,6 +132,10 @@
 	};
 };
 
+&cpu0 {
+	cpu0-supply = <&buck2_reg>;
+};
+
 &exynos_usbphy {
 	status = "okay";
 };
diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
index d7201333e3bc..e0f3b2ed41a3 100644
--- a/arch/arm/boot/dts/exynos3250.dtsi
+++ b/arch/arm/boot/dts/exynos3250.dtsi
@@ -53,6 +53,21 @@
 			compatible = "arm,cortex-a7";
 			reg = <0>;
 			clock-frequency = <1000000000>;
+			clocks = <&cmu CLK_ARM_CLK>;
+			clock-names = "cpu";
+
+			operating-points = <
+				1000000 1150000
+				900000  1112500
+				800000  1075000
+				700000  1037500
+				600000  1000000
+				500000  962500
+				400000  925000
+				300000  887500
+				200000  850000
+				100000  850000
+			>;
 		};
 
 		cpu1: cpu@1 {
-- 
1.8.5.5

[PATCH v6 3/3] ARM: exynos: Add exynos3250 compatible to use generic cpufreq driver

[Chanwoo Choi]

This patch add exynos3250 compatible string to exynos_cpufreq_matches
for supporting generic cpufreq driver on Exynos3250.

Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
 arch/arm/mach-exynos/exynos.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
index 4015ec369ae5..77ac0216ddc4 100644
--- a/arch/arm/mach-exynos/exynos.c
+++ b/arch/arm/mach-exynos/exynos.c
@@ -225,6 +225,7 @@ static void __init exynos_init_irq(void)
 }
 
 static const struct of_device_id exynos_cpufreq_matches[] = {
+	{ .compatible = "samsung,exynos3250", .data = "cpufreq-dt" },
 	{ .compatible = "samsung,exynos4210", .data = "cpufreq-dt" },
 	{ .compatible = "samsung,exynos5250", .data = "cpufreq-dt" },
 	{ /* sentinel */ }
-- 
1.8.5.5

Re: [PATCH v6 0/3] cpufreq: Use cpufreq-dt driver for Exynos3250

[Bartlomiej Zolnierkiewicz]

Hi,

On Thursday, July 02, 2015 09:42:38 AM Chanwoo Choi wrote:
> This patchset use cpufreq-dt driver to support Exynos3250 cpufreq and tested it
> on Exynos3250-based Rinato board.
> 
> Depends on:
> - next-20150701 tag (master branch) of linux-next kernel tree
> - This patch-set is based on Exynos5250 patch-set[1] because two patch-set
>   modify the 'arch/arm/mach-exynos/exynos.c' to add the compatible string.
>   [1] https://lkml.org/lkml/2015/6/29/361
>   : [PATCH v2 0/4] cpufreq: use generic cpufreq drivers for Exynos5250 platform
> 
> Changes from v5:
> (https://lkml.org/lkml/2015/7/1/324)
> - Reorder the cpu dt node in exynos3250-rinato/monk.dts alpabetically.
> - Add reviewed-by tag of Krzysztof Kozlowski <k.kozlowski@samsung.com>
> 
> Changes from v4:
> (https://lkml.org/lkml/2014/10/20/215)
> - Rebased on latest linux-next git repository.
> - Remove unnecessary divider clock flag from divider of DIV_CPU0/DIV_CPU1 register
> 
> Changes from v3:
> - This patchset is based on 3.18-rc1 with new patchset[3] of Thomas Abraham
>   [3] [PATCH v11 0/6] cpufreq: use generic cpufreq drivers for exynos platforms
>   - http://www.spinics.net/lists/arm-kernel/msg370412.html
> 
> Changes from v2:
> - Rebased on new patchset of Thomas Abraham
>   and for-next branch of samsunc-clk.git of Tomasz Figa
> 
> Changes from v1:
> - Rebased on new patchset[1] by Thomas Abraham
>   [1] [PATCH v10 0/6] cpufreq: use generic cpufreq drivers for exynos platforms
>   - http://www.spinics.net/lists/arm-kernel/msg364790.html
> - Modify clk-cpu.c to support Exynos3250
> - Drop documentation patch on previous patchset[2]
>   [2] http://www.spinics.net/lists/cpufreq/msg10265.html
> - Add only operating-points for Exynos3250 without armclk-divider-table
> 
> Chanwoo Choi (3):
>   clk: samsung: exynos3250: Add cpu clock configuration data and instaniate cpu clock
>   ARM: dts: Add CPU OPP and regulator supply property for Exynos3250
>   ARM: exynos: Add exynos3250 compatible to use generic cpufreq driver
> 
>  arch/arm/boot/dts/exynos3250-monk.dts   |  4 ++++
>  arch/arm/boot/dts/exynos3250-rinato.dts |  4 ++++
>  arch/arm/boot/dts/exynos3250.dtsi       | 15 +++++++++++++++
>  arch/arm/mach-exynos/exynos.c           |  1 +
>  drivers/clk/samsung/clk-exynos3250.c    | 32 ++++++++++++++++++++++++++++++--
>  include/dt-bindings/clock/exynos3250.h  |  1 +
>  6 files changed, 55 insertions(+), 2 deletions(-)

Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Thank you for working on this.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

RE: [PATCH v6 0/3] cpufreq: Use cpufreq-dt driver for Exynos3250

[Kukjin Kim]

Bartlomiej Zolnierkiewicz wrote:
> 
> Hi,
>
Hi,

> On Thursday, July 02, 2015 09:42:38 AM Chanwoo Choi wrote:
> > This patchset use cpufreq-dt driver to support Exynos3250 cpufreq and tested it
> > on Exynos3250-based Rinato board.
> >
> > Depends on:
> > - next-20150701 tag (master branch) of linux-next kernel tree
> > - This patch-set is based on Exynos5250 patch-set[1] because two patch-set
> >   modify the 'arch/arm/mach-exynos/exynos.c' to add the compatible string.
> >   [1] https://lkml.org/lkml/2015/6/29/361
> >   : [PATCH v2 0/4] cpufreq: use generic cpufreq drivers for Exynos5250 platform
> >
> > Changes from v5:
> > (https://lkml.org/lkml/2015/7/1/324)
> > - Reorder the cpu dt node in exynos3250-rinato/monk.dts alpabetically.
> > - Add reviewed-by tag of Krzysztof Kozlowski <k.kozlowski@samsung.com>
> >
> > Changes from v4:
> > (https://lkml.org/lkml/2014/10/20/215)
> > - Rebased on latest linux-next git repository.
> > - Remove unnecessary divider clock flag from divider of DIV_CPU0/DIV_CPU1 register
> >
> > Changes from v3:
> > - This patchset is based on 3.18-rc1 with new patchset[3] of Thomas Abraham
> >   [3] [PATCH v11 0/6] cpufreq: use generic cpufreq drivers for exynos platforms
> >   - http://www.spinics.net/lists/arm-kernel/msg370412.html
> >
> > Changes from v2:
> > - Rebased on new patchset of Thomas Abraham
> >   and for-next branch of samsunc-clk.git of Tomasz Figa
> >
> > Changes from v1:
> > - Rebased on new patchset[1] by Thomas Abraham
> >   [1] [PATCH v10 0/6] cpufreq: use generic cpufreq drivers for exynos platforms
> >   - http://www.spinics.net/lists/arm-kernel/msg364790.html
> > - Modify clk-cpu.c to support Exynos3250
> > - Drop documentation patch on previous patchset[2]
> >   [2] http://www.spinics.net/lists/cpufreq/msg10265.html
> > - Add only operating-points for Exynos3250 without armclk-divider-table
> >
> > Chanwoo Choi (3):
> >   clk: samsung: exynos3250: Add cpu clock configuration data and instaniate cpu clock
> >   ARM: dts: Add CPU OPP and regulator supply property for Exynos3250
> >   ARM: exynos: Add exynos3250 compatible to use generic cpufreq driver
> >
> >  arch/arm/boot/dts/exynos3250-monk.dts   |  4 ++++
> >  arch/arm/boot/dts/exynos3250-rinato.dts |  4 ++++
> >  arch/arm/boot/dts/exynos3250.dtsi       | 15 +++++++++++++++
> >  arch/arm/mach-exynos/exynos.c           |  1 +
> >  drivers/clk/samsung/clk-exynos3250.c    | 32 ++++++++++++++++++++++++++++++--
> >  include/dt-bindings/clock/exynos3250.h  |  1 +
> >  6 files changed, 55 insertions(+), 2 deletions(-)
> 
> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> 
> Thank you for working on this.
> 
+1 Thanks.

Mike and Sylwester, if you're OK on this series, I'd like to pick up in Samsung
tree together. And if you want, I could provide topic branch for clk tree.

Thanks,
Kukjin

RE: [PATCH v6 0/3] cpufreq: Use cpufreq-dt driver for Exynos3250

[Michael Turquette]

Quoting Kukjin Kim (2015-07-07 07:43:31)
> Bartlomiej Zolnierkiewicz wrote:
> > 
> > Hi,
> >
> Hi,
> 
> > On Thursday, July 02, 2015 09:42:38 AM Chanwoo Choi wrote:
> > > This patchset use cpufreq-dt driver to support Exynos3250 cpufreq and tested it
> > > on Exynos3250-based Rinato board.
> > >
> > > Depends on:
> > > - next-20150701 tag (master branch) of linux-next kernel tree
> > > - This patch-set is based on Exynos5250 patch-set[1] because two patch-set
> > >   modify the 'arch/arm/mach-exynos/exynos.c' to add the compatible string.
> > >   [1] https://lkml.org/lkml/2015/6/29/361
> > >   : [PATCH v2 0/4] cpufreq: use generic cpufreq drivers for Exynos5250 platform
> > >
> > > Changes from v5:
> > > (https://lkml.org/lkml/2015/7/1/324)
> > > - Reorder the cpu dt node in exynos3250-rinato/monk.dts alpabetically.
> > > - Add reviewed-by tag of Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > >
> > > Changes from v4:
> > > (https://lkml.org/lkml/2014/10/20/215)
> > > - Rebased on latest linux-next git repository.
> > > - Remove unnecessary divider clock flag from divider of DIV_CPU0/DIV_CPU1 register
> > >
> > > Changes from v3:
> > > - This patchset is based on 3.18-rc1 with new patchset[3] of Thomas Abraham
> > >   [3] [PATCH v11 0/6] cpufreq: use generic cpufreq drivers for exynos platforms
> > >   - http://www.spinics.net/lists/arm-kernel/msg370412.html
> > >
> > > Changes from v2:
> > > - Rebased on new patchset of Thomas Abraham
> > >   and for-next branch of samsunc-clk.git of Tomasz Figa
> > >
> > > Changes from v1:
> > > - Rebased on new patchset[1] by Thomas Abraham
> > >   [1] [PATCH v10 0/6] cpufreq: use generic cpufreq drivers for exynos platforms
> > >   - http://www.spinics.net/lists/arm-kernel/msg364790.html
> > > - Modify clk-cpu.c to support Exynos3250
> > > - Drop documentation patch on previous patchset[2]
> > >   [2] http://www.spinics.net/lists/cpufreq/msg10265.html
> > > - Add only operating-points for Exynos3250 without armclk-divider-table
> > >
> > > Chanwoo Choi (3):
> > >   clk: samsung: exynos3250: Add cpu clock configuration data and instaniate cpu clock
> > >   ARM: dts: Add CPU OPP and regulator supply property for Exynos3250
> > >   ARM: exynos: Add exynos3250 compatible to use generic cpufreq driver
> > >
> > >  arch/arm/boot/dts/exynos3250-monk.dts   |  4 ++++
> > >  arch/arm/boot/dts/exynos3250-rinato.dts |  4 ++++
> > >  arch/arm/boot/dts/exynos3250.dtsi       | 15 +++++++++++++++
> > >  arch/arm/mach-exynos/exynos.c           |  1 +
> > >  drivers/clk/samsung/clk-exynos3250.c    | 32 ++++++++++++++++++++++++++++++--
> > >  include/dt-bindings/clock/exynos3250.h  |  1 +
> > >  6 files changed, 55 insertions(+), 2 deletions(-)
> > 
> > Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > 
> > Thank you for working on this.
> > 
> +1 Thanks.
> 
> Mike and Sylwester, if you're OK on this series, I'd like to pick up in Samsung
> tree together. And if you want, I could provide topic branch for clk tree.

Kukjin,

A topic branch would be great.

Thanks,
Mike

> 
> Thanks,
> Kukjin
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v6 0/3] cpufreq: Use cpufreq-dt driver for Exynos3250

[Kukjin Kim]

On 07/24/15 09:30, Michael Turquette wrote:
> Quoting Kukjin Kim (2015-07-07 07:43:31)
>> Bartlomiej Zolnierkiewicz wrote:

[...]

>>>> Chanwoo Choi (3):
>>>>   clk: samsung: exynos3250: Add cpu clock configuration data and instaniate cpu clock
>>>>   ARM: dts: Add CPU OPP and regulator supply property for Exynos3250
>>>>   ARM: exynos: Add exynos3250 compatible to use generic cpufreq driver
>>>>
>>>>  arch/arm/boot/dts/exynos3250-monk.dts   |  4 ++++
>>>>  arch/arm/boot/dts/exynos3250-rinato.dts |  4 ++++
>>>>  arch/arm/boot/dts/exynos3250.dtsi       | 15 +++++++++++++++
>>>>  arch/arm/mach-exynos/exynos.c           |  1 +
>>>>  drivers/clk/samsung/clk-exynos3250.c    | 32 ++++++++++++++++++++++++++++++--
>>>>  include/dt-bindings/clock/exynos3250.h  |  1 +
>>>>  6 files changed, 55 insertions(+), 2 deletions(-)
>>>
>>> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>>>
>>> Thank you for working on this.
>>>
>> +1 Thanks.
>>
>> Mike and Sylwester, if you're OK on this series, I'd like to pick up in Samsung
>> tree together. And if you want, I could provide topic branch for clk tree.
> 
> Kukjin,
> 
> A topic branch would be great.
> 
Sure, BTW it means you did 'ack' on this clk change? If not, please let
em know ;-) I'll let you know once the topic branch is ready.

Thanks,
Kukjin

Re: [PATCH v6 0/3] cpufreq: Use cpufreq-dt driver for Exynos3250

[Kukjin Kim]

On 07/24/15 12:40, Kukjin Kim wrote:
> On 07/24/15 09:30, Michael Turquette wrote:
>> Quoting Kukjin Kim (2015-07-07 07:43:31)
>>> Bartlomiej Zolnierkiewicz wrote:
> 
> [...]
> 
>>>>> Chanwoo Choi (3):
>>>>>   clk: samsung: exynos3250: Add cpu clock configuration data and instaniate cpu clock
>>>>>   ARM: dts: Add CPU OPP and regulator supply property for Exynos3250
>>>>>   ARM: exynos: Add exynos3250 compatible to use generic cpufreq driver
>>>>>
>>>>>  arch/arm/boot/dts/exynos3250-monk.dts   |  4 ++++
>>>>>  arch/arm/boot/dts/exynos3250-rinato.dts |  4 ++++
>>>>>  arch/arm/boot/dts/exynos3250.dtsi       | 15 +++++++++++++++
>>>>>  arch/arm/mach-exynos/exynos.c           |  1 +
>>>>>  drivers/clk/samsung/clk-exynos3250.c    | 32 ++++++++++++++++++++++++++++++--
>>>>>  include/dt-bindings/clock/exynos3250.h  |  1 +
>>>>>  6 files changed, 55 insertions(+), 2 deletions(-)
>>>>
>>>> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>>>>
>>>> Thank you for working on this.
>>>>
>>> +1 Thanks.
>>>
>>> Mike and Sylwester, if you're OK on this series, I'd like to pick up in Samsung
>>> tree together. And if you want, I could provide topic branch for clk tree.
>>
>> Kukjin,
>>
>> A topic branch would be great.
>>
> Sure, BTW it means you did 'ack' on this clk change? If not, please let
> em know ;-) I'll let you know once the topic branch is ready.
> 
Mike,

Done, the topic branch 'v4.3-topic/clk-samsung' in samsung tree is for
your clk tree.

Thanks,
Kukjin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v6 0/3] cpufreq: Use cpufreq-dt driver for Exynos3250

[Michael Turquette]

Quoting Kukjin Kim (2015-07-23 21:08:27)
> On 07/24/15 12:40, Kukjin Kim wrote:
> > On 07/24/15 09:30, Michael Turquette wrote:
> >> Quoting Kukjin Kim (2015-07-07 07:43:31)
> >>> Bartlomiej Zolnierkiewicz wrote:
> > 
> > [...]
> > 
> >>>>> Chanwoo Choi (3):
> >>>>>   clk: samsung: exynos3250: Add cpu clock configuration data and instaniate cpu clock
> >>>>>   ARM: dts: Add CPU OPP and regulator supply property for Exynos3250
> >>>>>   ARM: exynos: Add exynos3250 compatible to use generic cpufreq driver
> >>>>>
> >>>>>  arch/arm/boot/dts/exynos3250-monk.dts   |  4 ++++
> >>>>>  arch/arm/boot/dts/exynos3250-rinato.dts |  4 ++++
> >>>>>  arch/arm/boot/dts/exynos3250.dtsi       | 15 +++++++++++++++
> >>>>>  arch/arm/mach-exynos/exynos.c           |  1 +
> >>>>>  drivers/clk/samsung/clk-exynos3250.c    | 32 ++++++++++++++++++++++++++++++--
> >>>>>  include/dt-bindings/clock/exynos3250.h  |  1 +
> >>>>>  6 files changed, 55 insertions(+), 2 deletions(-)
> >>>>
> >>>> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> >>>>
> >>>> Thank you for working on this.
> >>>>
> >>> +1 Thanks.
> >>>
> >>> Mike and Sylwester, if you're OK on this series, I'd like to pick up in Samsung
> >>> tree together. And if you want, I could provide topic branch for clk tree.
> >>
> >> Kukjin,
> >>
> >> A topic branch would be great.
> >>
> > Sure, BTW it means you did 'ack' on this clk change? If not, please let
> > em know ;-) I'll let you know once the topic branch is ready.
> > 
> Mike,
> 
> Done, the topic branch 'v4.3-topic/clk-samsung' in samsung tree is for
> your clk tree.

Thanks!

Mike

> 
> Thanks,
> Kukjin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v6 0/3] cpufreq: Use cpufreq-dt driver for Exynos3250

[Krzysztof Kozlowski]

On 24.07.2015 12:40, Kukjin Kim wrote:
> On 07/24/15 09:30, Michael Turquette wrote:
>> Quoting Kukjin Kim (2015-07-07 07:43:31)
>>> Bartlomiej Zolnierkiewicz wrote:
> 
> [...]
> 
>>>>> Chanwoo Choi (3):
>>>>>   clk: samsung: exynos3250: Add cpu clock configuration data and instaniate cpu clock
>>>>>   ARM: dts: Add CPU OPP and regulator supply property for Exynos3250
>>>>>   ARM: exynos: Add exynos3250 compatible to use generic cpufreq driver
>>>>>
>>>>>  arch/arm/boot/dts/exynos3250-monk.dts   |  4 ++++
>>>>>  arch/arm/boot/dts/exynos3250-rinato.dts |  4 ++++
>>>>>  arch/arm/boot/dts/exynos3250.dtsi       | 15 +++++++++++++++
>>>>>  arch/arm/mach-exynos/exynos.c           |  1 +
>>>>>  drivers/clk/samsung/clk-exynos3250.c    | 32 ++++++++++++++++++++++++++++++--
>>>>>  include/dt-bindings/clock/exynos3250.h  |  1 +
>>>>>  6 files changed, 55 insertions(+), 2 deletions(-)
>>>>
>>>> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>>>>
>>>> Thank you for working on this.
>>>>
>>> +1 Thanks.
>>>
>>> Mike and Sylwester, if you're OK on this series, I'd like to pick up in Samsung
>>> tree together. And if you want, I could provide topic branch for clk tree.
>>
>> Kukjin,
>>
>> A topic branch would be great.
>>
> Sure, BTW it means you did 'ack' on this clk change? If not, please let
> em know ;-) I'll let you know once the topic branch is ready.

Dear Kukjin,

Will you handle this patchset and dependants (ARM: dts: Add CPU cooling
binding for Exynos3250-based Rinato/Monk board) for v4.3?

Best regards,
Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH v6 0/3] cpufreq: Use cpufreq-dt driver for Exynos3250

[Kukjin Kim]

Krzysztof Kozlowski wrote:
> 
> On 24.07.2015 12:40, Kukjin Kim wrote:
> > On 07/24/15 09:30, Michael Turquette wrote:
> >> Quoting Kukjin Kim (2015-07-07 07:43:31)
> >>> Bartlomiej Zolnierkiewicz wrote:
> >
> > [...]
> >
> >>>>> Chanwoo Choi (3):
> >>>>>   clk: samsung: exynos3250: Add cpu clock configuration data and instaniate cpu clock
> >>>>>   ARM: dts: Add CPU OPP and regulator supply property for Exynos3250
> >>>>>   ARM: exynos: Add exynos3250 compatible to use generic cpufreq driver
> >>>>>
> >>>>>  arch/arm/boot/dts/exynos3250-monk.dts   |  4 ++++
> >>>>>  arch/arm/boot/dts/exynos3250-rinato.dts |  4 ++++
> >>>>>  arch/arm/boot/dts/exynos3250.dtsi       | 15 +++++++++++++++
> >>>>>  arch/arm/mach-exynos/exynos.c           |  1 +
> >>>>>  drivers/clk/samsung/clk-exynos3250.c    | 32 ++++++++++++++++++++++++++++++--
> >>>>>  include/dt-bindings/clock/exynos3250.h  |  1 +
> >>>>>  6 files changed, 55 insertions(+), 2 deletions(-)
> >>>>
> >>>> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> >>>>
> >>>> Thank you for working on this.
> >>>>
> >>> +1 Thanks.
> >>>
> >>> Mike and Sylwester, if you're OK on this series, I'd like to pick up in Samsung
> >>> tree together. And if you want, I could provide topic branch for clk tree.
> >>
> >> Kukjin,
> >>
> >> A topic branch would be great.
> >>
> > Sure, BTW it means you did 'ack' on this clk change? If not, please let
> > em know ;-) I'll let you know once the topic branch is ready.
> 
> Dear Kukjin,
> 
> Will you handle this patchset and dependants (ARM: dts: Add CPU cooling
> binding for Exynos3250-based Rinato/Monk board) for v4.3?
> 
You mean Chanwoo's patch. Yes, I'll. Thanks for your gentle reminder.

- Kukjin

Re: [PATCH v6 0/3] cpufreq: Use cpufreq-dt driver for Exynos3250

[Chanwoo Choi]

Dear Kukjin,

On Sat, Jul 25, 2015 at 11:11 AM, Kukjin Kim <kgene@kernel.org> wrote:
> Krzysztof Kozlowski wrote:
>>
>> On 24.07.2015 12:40, Kukjin Kim wrote:
>> > On 07/24/15 09:30, Michael Turquette wrote:
>> >> Quoting Kukjin Kim (2015-07-07 07:43:31)
>> >>> Bartlomiej Zolnierkiewicz wrote:
>> >
>> > [...]
>> >
>> >>>>> Chanwoo Choi (3):
>> >>>>>   clk: samsung: exynos3250: Add cpu clock configuration data and instaniate cpu clock
>> >>>>>   ARM: dts: Add CPU OPP and regulator supply property for Exynos3250
>> >>>>>   ARM: exynos: Add exynos3250 compatible to use generic cpufreq driver
>> >>>>>
>> >>>>>  arch/arm/boot/dts/exynos3250-monk.dts   |  4 ++++
>> >>>>>  arch/arm/boot/dts/exynos3250-rinato.dts |  4 ++++
>> >>>>>  arch/arm/boot/dts/exynos3250.dtsi       | 15 +++++++++++++++
>> >>>>>  arch/arm/mach-exynos/exynos.c           |  1 +
>> >>>>>  drivers/clk/samsung/clk-exynos3250.c    | 32 ++++++++++++++++++++++++++++++--
>> >>>>>  include/dt-bindings/clock/exynos3250.h  |  1 +
>> >>>>>  6 files changed, 55 insertions(+), 2 deletions(-)
>> >>>>
>> >>>> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>> >>>>
>> >>>> Thank you for working on this.
>> >>>>
>> >>> +1 Thanks.
>> >>>
>> >>> Mike and Sylwester, if you're OK on this series, I'd like to pick up in Samsung
>> >>> tree together. And if you want, I could provide topic branch for clk tree.
>> >>
>> >> Kukjin,
>> >>
>> >> A topic branch would be great.
>> >>
>> > Sure, BTW it means you did 'ack' on this clk change? If not, please let
>> > em know ;-) I'll let you know once the topic branch is ready.
>>
>> Dear Kukjin,
>>
>> Will you handle this patchset and dependants (ARM: dts: Add CPU cooling
>> binding for Exynos3250-based Rinato/Monk board) for v4.3?
>>
> You mean Chanwoo's patch. Yes, I'll. Thanks for your gentle reminder.

Please pick following patch[1] kindly. Following patch is about cooling device
for Exynos3250-based Rinato/Monk board.
[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/354693.html

Best Regards,
Chanwoo Choi