Re: [PATCH v3 4/6] power: da9150: Add DT bindings documentation for Fuel-Gauge

[Sebastian Reichel <sre@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]

Hi,

On Tue, Jul 07, 2015 at 05:34:21PM +0100, Adam Thomson wrote:
> diff --git a/Documentation/devicetree/bindings/power/da9150-fg.txt b/Documentation/devicetree/bindings/power/da9150-fg.txt
> new file mode 100644
> index 0000000..c3c76eb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/da9150-fg.txt
> @@ -0,0 +1,23 @@
> +Dialog Semiconductor DA9150 Fuel-Gauge Power Supply bindings
> +
> +Required properties:
> +- compatible: "dlg,da9150-fg" for DA9150 Fuel-Gauge Power Supply
                  ^^^^^^^^^^^^^

s/dlg,da9150-fg/dlg,da9150-fuel-gauge/g

> +Optional properties:
> +- dlg,update-interval: Interval time (milliseconds) between battery level checks.
> +- dlg,warn-soc-level: Battery discharge level (%) where warning event raised.
> +      [1 - 100]
> +- dlg,crit-soc-level: Battery discharge level (%) where critical event raised.
> +  This value should be lower than the warning level.
> +      [1 - 100]
> +
> +
> +Example:
> +
> +	da9150-fg {

Make this just "fuel-gauge".

> +		compatible = "dlg,da9150-fg";
                      ^^^^^^^^^^^^^

here too ;)

> +
> +		dlg,update-interval = <10000>;
> +		dlg,warn-soc-level = /bits/ 8 <15>;
> +		dlg,crit-soc-level = /bits/ 8 <5>;
> +	};

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]