From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [RFC] ARM: dts: sunxi: Add regulators and board-specific operating points for LeMaker BananaPi Date: Tue, 28 Jul 2015 14:55:45 +0200 Message-ID: <20150728125545.GC2564@lukather> References: <1437960486-2809-1-git-send-email-public_timo.s@silentcreek.de> <55B5E6DB.8020009@redhat.com> <20150727123653.36C046C8007E@dd34104.kasserver.com> <55B62A1B.6030601@redhat.com> <20150728090216.892076C80D94@dd34104.kasserver.com> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ChCJQocta8D2pgCp" Return-path: Content-Disposition: inline In-Reply-To: <20150728090216.892076C80D94-RzmsueL7+k6AvxNu/8lEInnhMCiq3JZZ@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Timo Sigurdsson Cc: hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org List-Id: devicetree@vger.kernel.org --ChCJQocta8D2pgCp Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Tue, Jul 28, 2015 at 11:02:16AM +0200, Timo Sigurdsson wrote: > Hi, > > Chen-Yu Tsai schrieb am 27.07.2015 15:14: > >> ChenYu (in the CC), since you did most of the original work here, do > >> you know why we have an op at 0.9 volt, but none of our boards allow the > >> voltage to go that low in the regulator settings ? > > > > I'm on vacation now, so apologies for the bad formatting. > > > > The OPPs are from a common subset > > of the settings from the fex files available > > at the time. Some fex files actually set > > min and max voltage thus eliminating > > the highest and lowest OPPs. > > > > At least that is how Maxime and I > > interpreted them. > > IMHO for a common maximum opp that's a good approach. But for the lowest > frequency setting, it would seem more logical to me, to raise the voltage > to a point where all boards will run fine with them, unless those boards > cannot handle the frequency regardless of the higher voltage. Agreed. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --ChCJQocta8D2pgCp--