Devicetree
 help / color / mirror / Atom feed
From: Peter Griffin <peter.griffin@linaro.org>
To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com,
	maxime.coquelin@st.com, patrice.chotard@st.com,
	lee.jones@linaro.org, hugues.fruchet@st.com,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 02/12] [media] dvb-pll: Add support for THOMSON DTT7546X tuner.
Date: Thu, 30 Jul 2015 10:46:11 +0100	[thread overview]
Message-ID: <20150730094611.GC488@griffinp-ThinkPad-X1-Carbon-2nd> (raw)
In-Reply-To: <20150722141040.2be3ca98@recife.lan>

Hi Mauro,

On Wed, 22 Jul 2015, Mauro Carvalho Chehab wrote:

> Em Wed, 24 Jun 2015 16:11:00 +0100
> Peter Griffin <peter.griffin@linaro.org> escreveu:
> 
> > This is used in conjunction with the STV0367 demodulator on
> > the STV0367-NIM-V1.0 NIM card which can be used with the STi
> > STB SoC's.
> > 
> > This tuner has a fifth register, so some changes have been made
> > to accommodate this.
> > 
> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> > ---
> >  drivers/media/dvb-frontends/dvb-pll.c | 74 +++++++++++++++++++++++++++++------
> >  drivers/media/dvb-frontends/dvb-pll.h |  1 +
> >  2 files changed, 64 insertions(+), 11 deletions(-)
> > 
> > diff --git a/drivers/media/dvb-frontends/dvb-pll.c b/drivers/media/dvb-frontends/dvb-pll.c
> > index 6d8fe88..f7381c7 100644
> > --- a/drivers/media/dvb-frontends/dvb-pll.c
> > +++ b/drivers/media/dvb-frontends/dvb-pll.c
> > @@ -141,6 +141,35 @@ static struct dvb_pll_desc dvb_pll_thomson_dtt7520x = {
> >  	},
> >  };
> >  
> > +static void thomson_dtt7546x_bw(struct dvb_frontend *fe, u8 *buf)
> > +{
> > +	/* set CB2 reg - set ATC, XTO */
> > +	buf[4] = 0xc3;
> > +}
> > +
> > +static struct dvb_pll_desc dvb_pll_thomson_dtt7546x = {
> > +	.name  = "Thomson dtt7546x",
> > +	.min   = 44250000,
> > +	.max   = 863250000,
> > +	.set   = thomson_dtt7546x_bw,
> > +	.iffreq= 36166667,
> 
> Whitespace is missing. Please check the patchs with scripts/checkpatch.pl.

Will fix in V2.

regards,

Peter.

  reply	other threads:[~2015-07-30  9:46 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-24 15:10 [PATCH 00/12] Add c8sectpfe LinuxDVB demux driver Peter Griffin
2015-06-24 15:10 ` [PATCH 01/12] ARM: DT: STi: stihxxx-b2120: Add pulse-width properties to ssc2 & ssc3 Peter Griffin
2015-06-24 15:11 ` [PATCH 03/12] [media] stv0367: Refine i2c error trace to include i2c address Peter Griffin
2015-06-24 15:11 ` [PATCH 04/12] [media] stv0367: Add support for 16Mhz reference clock Peter Griffin
2015-06-24 15:11 ` [PATCH 05/12] [media] tsin: c8sectpfe: Add DT bindings documentation for c8sectpfe driver Peter Griffin
2015-06-24 15:11 ` [PATCH 06/12] ARM: DT: STi: STiH407: Add c8sectpfe LinuxDVB DT node Peter Griffin
2015-06-24 15:11 ` [PATCH 07/12] [media] tsin: c8sectpfe: STiH407/10 Linux DVB demux support Peter Griffin
     [not found]   ` <1435158670-7195-8-git-send-email-peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-07-22 21:46     ` Mauro Carvalho Chehab
2015-07-30 11:08       ` Peter Griffin
2015-06-24 15:11 ` [PATCH 08/12] [media] tsin: c8sectpfe: Add LDVB helper functions Peter Griffin
     [not found] ` <1435158670-7195-1-git-send-email-peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-06-24 15:11   ` [PATCH 02/12] [media] dvb-pll: Add support for THOMSON DTT7546X tuner Peter Griffin
     [not found]     ` <1435158670-7195-3-git-send-email-peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-06-25  1:17       ` Joe Perches
2015-07-22 21:58         ` Mauro Carvalho Chehab
     [not found]           ` <20150722185811.2d718baa-+RedX5hVuTR+urZeOPWqwQ@public.gmane.org>
2015-07-30  9:47             ` Peter Griffin
2015-07-30 10:08               ` Joe Perches
     [not found]                 ` <1438250928.2677.10.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2015-07-30 11:14                   ` Michael Ira Krufky
     [not found]                     ` <CAOcJUbw5hSmPdrz6rPPYU6iMBHnvOZc1p3f+4WhEYq2-XmAPVw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-30 11:17                       ` Michael Ira Krufky
2015-07-30 14:33                         ` Peter Griffin
2015-07-30 11:37                     ` Michael Ira Krufky
2015-07-30 14:34                       ` Peter Griffin
2015-07-22 17:10     ` Mauro Carvalho Chehab
2015-07-30  9:46       ` Peter Griffin [this message]
2015-06-24 15:11   ` [PATCH 09/12] [media] tsin: c8sectpfe: Add support for various ST NIM cards Peter Griffin
2015-07-22 21:53     ` Mauro Carvalho Chehab
2015-07-30  9:43       ` Peter Griffin
2015-06-24 15:11   ` [PATCH 10/12] [media] tsin: c8sectpfe: Add c8sectpfe debugfs support Peter Griffin
2015-06-24 15:11   ` [PATCH 11/12] [media] tsin: c8sectpfe: Add Kconfig and Makefile for the driver Peter Griffin
2015-06-25  7:23     ` Paul Bolle
2015-07-22  7:38       ` Peter Griffin
2015-07-22 21:56     ` Mauro Carvalho Chehab
2015-07-30  9:39       ` Peter Griffin
2015-06-24 15:11   ` [PATCH 12/12] MAINTAINERS: Add c8sectpfe driver directory to STi section Peter Griffin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150730094611.GC488@griffinp-ThinkPad-X1-Carbon-2nd \
    --to=peter.griffin@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hugues.fruchet@st.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=maxime.coquelin@st.com \
    --cc=mchehab@osg.samsung.com \
    --cc=patrice.chotard@st.com \
    --cc=srinivas.kandagatla@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox