From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 3/3] input: cyapa: fix output unwanted warning issue Date: Thu, 30 Jul 2015 11:33:34 -0700 Message-ID: <20150730183334.GJ13165@dtor-ws> References: <1437714359-2484-1-git-send-email-dudl@cypress.com> <1437714359-2484-4-git-send-email-dudl@cypress.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1437714359-2484-4-git-send-email-dudl-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dudley Du Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, bleung-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, jmmahler-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, Jul 24, 2015 at 01:05:59PM +0800, Dudley Du wrote: > Avoid the driver generate warning message when the cyapa driver working > with the old Gen5 trackpad device which does not support the proximity function. > Those old Gen5 trackpad device all have the platform version less than 2. > > Signed-off-by: Dudley Du Applied, thank you. > --- > drivers/input/mouse/cyapa_gen5.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/input/mouse/cyapa_gen5.c b/drivers/input/mouse/cyapa_gen5.c > index 6d7abbe..118ba97 100644 > --- a/drivers/input/mouse/cyapa_gen5.c > +++ b/drivers/input/mouse/cyapa_gen5.c > @@ -2519,10 +2519,13 @@ static int cyapa_gen5_do_operational_check(struct cyapa *cyapa) > __func__); > > /* By default, the trackpad proximity function is enabled. */ > - error = cyapa_pip_set_proximity(cyapa, true); > - if (error) > - dev_warn(dev, "%s: failed to enable proximity.\n", > - __func__); > + if (cyapa->platform_ver >= 2) { > + error = cyapa_pip_set_proximity(cyapa, true); > + if (error) > + dev_warn(dev, > + "%s: failed to enable proximity.\n", > + __func__); > + } > > /* Get trackpad product information. */ > error = cyapa_gen5_get_query_data(cyapa); > -- > 1.9.1 > > > --------------------------------------------------------------- > This message and any attachments may contain Cypress (or its > subsidiaries) confidential information. If it has been received > in error, please advise the sender and immediately delete this > message. > --------------------------------------------------------------- > -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html