Re: [RFC] improve binding for linux,wdt-gpio

["Uwe Kleine-König" <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]

Hello,

while hacking on the gpio driver I found yet another ambiguity:

On Tue, Jul 28, 2015 at 10:33:48PM +0200, Uwe Kleine-König wrote:
> -  - level: Low or high level starts counting WDT timeout,
> -    the opposite level disables the WDT. Active level is determined
> -    by the GPIO flags.
The driver as is does the following when

	gpio = <&gpiocontroler 5 GPIO_ACTIVE_LOW>

is specified in the device tree:

	priv->active_low = flags & OF_GPIO_ACTIVE_LOW;

So active_low is 1 for us with the above device tree snippet.

Then in the disable callback the driver does:

	gpio_set_value_cansleep(priv->gpio, !priv->active_low);

so the gpio is set to 0 to disable the chip. I would have expected it
the other way round! (Is this only me?) So the documentation should
point that out that the active level of the GPIO is supposed to disable the
chip.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html