devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH 4/5] ARM: dts: sun8i: Enable USB DRC on Ippo Q8H-A33 tablet
Date: Fri, 31 Jul 2015 12:08:22 +0200	[thread overview]
Message-ID: <20150731100822.GA2564@lukather> (raw)
In-Reply-To: <1438333194-21181-5-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 641 bytes --]

Hi,

On Fri, Jul 31, 2015 at 10:59:53AM +0200, Hans de Goede wrote:
> Enable the otg/drc usb controller on the Ippo Q8H-A33 tablet, for now it
> is enabled in host-only mode, because true OTG support requires support
> for detecting and enabling Vbus through the axp221 pmic.
> 
> For this to work the Vbus on the port must be enabled by u-boot,
> or a powered hub must be used.

A comment on top of the usb_otg node stating that would be great. It
stands out more when we want to refactor stuff (with a FIXME even?).

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2015-07-31 10:08 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-31  8:59 [PATCH 0/5] ARM: dts: sunxi: Enable USB DRC on a bunch of boards Hans de Goede
     [not found] ` <1438333194-21181-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-07-31  8:59   ` [PATCH 1/5] ARM: dts: sun4i: Enable USB DRC on A10 OLinuxIno Lime Hans de Goede
     [not found]     ` <1438333194-21181-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-07-31 10:10       ` Maxime Ripard
2015-07-31  8:59   ` [PATCH 2/5] ARM: dts: sun5i: Enable USB DRC on A10s OLinuxIno Micro Hans de Goede
     [not found]     ` <1438333194-21181-3-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-07-31 10:11       ` Maxime Ripard
2015-07-31  8:59   ` [PATCH 3/5] ARM: dts: sun5i: Enable USB DRC on A13 OLinuxIno Hans de Goede
     [not found]     ` <1438333194-21181-4-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-07-31 10:11       ` Maxime Ripard
2015-07-31  8:59   ` [PATCH 4/5] ARM: dts: sun8i: Enable USB DRC on Ippo Q8H-A33 tablet Hans de Goede
     [not found]     ` <1438333194-21181-5-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-07-31 10:08       ` Maxime Ripard [this message]
2015-07-31  8:59   ` [PATCH 5/5] ARM: dts: sun7i: Add dts file for Wits Pro A20 DKT Hans de Goede
     [not found]     ` <1438333194-21181-6-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-07-31 10:20       ` Maxime Ripard
2015-07-31 10:25         ` Chen-Yu Tsai
     [not found]           ` <CAGb2v65TEogqYFAfen1VnOaiepvez5t8Oh+Q=OYsRS_aZUMO3A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-31 12:45             ` [linux-sunxi] " Hans de Goede
2015-07-31 16:13             ` Hans de Goede
     [not found]               ` <55BB9E92.30604-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-07-31 17:33                 ` Chen-Yu Tsai
2015-08-01  9:30                 ` Maxime Ripard
2015-08-02 12:58                   ` Hans de Goede
2015-08-02 13:00                   ` [linux-sunxi] " Hans de Goede
2015-07-31 16:56             ` Maxime Ripard
2015-07-31 17:28               ` Chen-Yu Tsai
2015-07-31 18:02               ` [linux-sunxi] " Hans de Goede
     [not found]                 ` <55BBB840.80107-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-08-01  9:18                   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150731100822.GA2564@lukather \
    --to=maxime.ripard-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).