From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 4/5] ARM: dts: sun8i: Enable USB DRC on Ippo Q8H-A33 tablet Date: Fri, 31 Jul 2015 12:08:22 +0200 Message-ID: <20150731100822.GA2564@lukather> References: <1438333194-21181-1-git-send-email-hdegoede@redhat.com> <1438333194-21181-5-git-send-email-hdegoede@redhat.com> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4loEm8vkm2dPEmEM" Return-path: Content-Disposition: inline In-Reply-To: <1438333194-21181-5-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Hans de Goede Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org --4loEm8vkm2dPEmEM Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Hi, On Fri, Jul 31, 2015 at 10:59:53AM +0200, Hans de Goede wrote: > Enable the otg/drc usb controller on the Ippo Q8H-A33 tablet, for now it > is enabled in host-only mode, because true OTG support requires support > for detecting and enabling Vbus through the axp221 pmic. > > For this to work the Vbus on the port must be enabled by u-boot, > or a powered hub must be used. A comment on top of the usb_otg node stating that would be great. It stands out more when we want to refactor stuff (with a FIXME even?). Thanks, Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --4loEm8vkm2dPEmEM--