Re: [RFCv3 4/4] ARM: zynq: Select ARCH_HAS_RESET_CONTROLLER

From: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: mark.rutland@arm.com, Moritz Fischer <moritz.fischer@ettus.com>,
	linux@arm.linux.org.uk, pawel.moll@arm.com,
	ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, robh+dt@kernel.org,
	p.zabel@pengutronix.de, galak@codeaurora.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFCv3 4/4] ARM: zynq: Select ARCH_HAS_RESET_CONTROLLER
Date: Fri, 31 Jul 2015 09:47:07 -0700	[thread overview]
Message-ID: <20150731164707.GF2650@xsjsorenbubuntu> (raw)
In-Reply-To: <55BB2D39.6000004@xilinx.com>

On Fri, 2015-07-31 at 10:09AM +0200, Michal Simek wrote:
> On 07/31/2015 03:13 AM, Moritz Fischer wrote:
> > Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
> > ---
> >  arch/arm/mach-zynq/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm/mach-zynq/Kconfig b/arch/arm/mach-zynq/Kconfig
> > index 78e5e00..77d7df7 100644
> > --- a/arch/arm/mach-zynq/Kconfig
> > +++ b/arch/arm/mach-zynq/Kconfig
> > @@ -1,5 +1,6 @@
> >  config ARCH_ZYNQ
> >  	bool "Xilinx Zynq ARM Cortex A9 Platform" if ARCH_MULTI_V7
> > +	select ARCH_HAS_RESET_CONTROLLER
> >  	select ARCH_SUPPORTS_BIG_ENDIAN
> >  	select ARM_AMBA
> >  	select ARM_GIC
> > 
> 
> Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Acked-by: Sören Brinkmann <soren.brinkmann@xilinx.com>

I personally, would prefer to decouple the logical outputs of the
reset-controller from the HW. But, as Moritz pointed out, that seems
rather uncommon for reset controllers. I think this is good to go.

	Thanks,
	Sören

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel