Re: [PATCH 5/8] ARM: AM43xx: Introduce a separate soc_is function for am438x series of SoCs

[Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>]

* Keerthy <j-keerthy-l0cyMroinI0@public.gmane.org> [150805 03:53]:
> --- a/arch/arm/mach-omap2/id.c
> +++ b/arch/arm/mach-omap2/id.c
> @@ -228,6 +228,8 @@ static void __init omap3_cpuinfo(void)
>  		cpu_name =  "AM335X";
>  	} else if (soc_is_am437x()) {
>  		cpu_name =  "AM437x";
> +	} else if (soc_is_am438x()) {
> +		cpu_name =  "AM438X";
>  	} else if (cpu_is_ti814x()) {
>  		cpu_name = "TI814X";
>  	} else if (omap3_has_iva() && omap3_has_sgx()) {
> --- a/arch/arm/mach-omap2/soc.h
> +++ b/arch/arm/mach-omap2/soc.h
> @@ -238,6 +238,7 @@ IS_AM_SUBCLASS(437x, 0x437)
>  #define soc_is_am335x()			0
>  #define soc_is_am43xx()			0
>  #define soc_is_am437x()			0
> +#define soc_is_am438x()			0
>  #define cpu_is_omap44xx()		0
>  #define cpu_is_omap443x()		0
>  #define cpu_is_omap446x()		0
> @@ -371,8 +372,10 @@ IS_OMAP_TYPE(3430, 0x3430)
>  #ifdef	CONFIG_SOC_AM43XX
>  # undef soc_is_am43xx
>  # undef soc_is_am437x
> -# define soc_is_am43xx()		is_am43xx()
> -# define soc_is_am437x()		is_am437x()
> +# undef soc_is_am438x
> +# define soc_is_am43xx()		of_machine_is_compatible("ti,am43")
> +# define soc_is_am437x()		of_machine_is_compatible("ti,am4372")
> +# define soc_is_am438x()		of_machine_is_compatible("ti,am438x")
>  #endif
>  
>  # if defined(CONFIG_ARCH_OMAP4)

Nice if we can start getting rid of the early SoC detection. But
With this change to use of_machine_is_compatible we need to make
sure nothing relies on it too early in the init. And we should
then do it for all the SoCs that boot in dts mode to avoid making
them behave in a different way.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html