From: Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
Cc: Keerthy <j-keerthy-l0cyMroinI0@public.gmane.org>,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
balbi-l0cyMroinI0@public.gmane.org,
nm-l0cyMroinI0@public.gmane.org,
paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org,
t-kristo-l0cyMroinI0@public.gmane.org
Subject: Re: [PATCH 3/8] rtc: omap: Add external clock enabling support
Date: Wed, 5 Aug 2015 13:43:57 +0200 [thread overview]
Message-ID: <20150805114357.GG3486@piout.net> (raw)
In-Reply-To: <20150805114119.GF3486-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
On 05/08/2015 at 13:41:19 +0200, Alexandre Belloni wrote :
> Hi,
>
> On 05/08/2015 at 04:13:17 -0700, Tony Lindgren wrote :
> > * Keerthy <j-keerthy-l0cyMroinI0@public.gmane.org> [150805 03:53]:
> > > Based on the board property switch the source from internal
> > > to external clock. Switching to external source is needed for
> > > rtcwake to work in low power modes.
> >
> > I think this is better handled based on the compatible string
> > in the device driver rather than introducing a custom dts
> > property for it. You can just set the quirk flag in the driver
> > probe based on the compatible.
> >
>
> Why not use the clocks property? Then you can pass an external clock. If
> it is present you can even get its rate if this is needed at some point
> in the future. You could also disable it when going to suspend.
>
Actually, that was already my suggestion back in april:
http://patchwork.ozlabs.org/patch/445631/
(Please Cc: the rtc mailing list for RTC related patches so that they
get picked up by patchwork).
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-08-05 11:43 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 10:49 [PATCH 0/8] ARM: AM4372: Enable RTC Keerthy
[not found] ` <1438771792-12604-1-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>
2015-08-05 10:49 ` [PATCH 1/8] ARM: dts: AM4372: Reorder the rtc compatible string Keerthy
[not found] ` <1438771792-12604-2-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>
2015-08-05 15:31 ` Felipe Balbi
[not found] ` <20150805153148.GB12328-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org>
2015-08-05 15:51 ` Keerthy
[not found] ` <55C230E9.9010309-l0cyMroinI0@public.gmane.org>
2015-08-05 16:14 ` Felipe Balbi
[not found] ` <20150805161445.GF12328-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org>
2015-08-05 16:18 ` Keerthy
[not found] ` <55C23740.2080102-l0cyMroinI0@public.gmane.org>
2015-08-05 16:51 ` Felipe Balbi
[not found] ` <20150805165122.GH12328-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org>
2015-08-06 1:25 ` Keerthy
[not found] ` <55C2B7A5.5000400-l0cyMroinI0@public.gmane.org>
2015-08-06 14:16 ` Felipe Balbi
[not found] ` <20150806141618.GA19110-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org>
2015-08-06 16:48 ` Keerthy
[not found] ` <55C38FCC.1040306-l0cyMroinI0@public.gmane.org>
2015-08-07 2:47 ` Tony Lindgren
2015-08-06 13:33 ` Afzal Mohammed
2015-08-05 10:49 ` [PATCH 2/8] ARM: dts: am437x-gp-evm: Add regulator-always-on and regulator-boot-on for RTC DCDCs Keerthy
[not found] ` <1438771792-12604-3-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>
2015-08-05 11:20 ` Tony Lindgren
2015-08-05 10:49 ` [PATCH 3/8] rtc: omap: Add external clock enabling support Keerthy
[not found] ` <1438771792-12604-4-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>
2015-08-05 11:13 ` Tony Lindgren
[not found] ` <20150805111316.GI16878-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-08-05 11:41 ` Alexandre Belloni
[not found] ` <20150805114119.GF3486-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
2015-08-05 11:43 ` Alexandre Belloni [this message]
[not found] ` <20150805114357.GG3486-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
2015-08-05 12:01 ` Keerthy
[not found] ` <55C1FB12.1000208-l0cyMroinI0@public.gmane.org>
2015-08-05 12:35 ` Alexandre Belloni
[not found] ` <20150805123550.GH3486-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
2015-08-06 2:09 ` Keerthy
[not found] ` <55C2C1F0.9040102-l0cyMroinI0@public.gmane.org>
2015-08-06 8:44 ` Alexandre Belloni
2015-08-06 9:36 ` Grygorii Strashko
[not found] ` <55C32AB6.7090509-l0cyMroinI0@public.gmane.org>
2015-08-06 9:47 ` Alexandre Belloni
[not found] ` <20150806094736.GM3486-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
2015-08-06 9:51 ` Tony Lindgren
[not found] ` <20150806095105.GD4215-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-08-07 8:20 ` Keerthy
2015-08-05 10:49 ` [PATCH 4/8] ARM: dts: AM4372: Add external clock flag Keerthy
2015-08-05 10:49 ` [PATCH 5/8] ARM: AM43xx: Introduce a separate soc_is function for am438x series of SoCs Keerthy
[not found] ` <1438771792-12604-6-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>
2015-08-05 11:16 ` Tony Lindgren
2015-08-05 10:49 ` [PATCH 6/8] ARM: dts: am43x-epos-evm: Add the am438 compatible string Keerthy
2015-08-05 10:49 ` [PATCH 7/8] ARM: AM43XX: HWMOD: Add rtc hwmod Keerthy
2015-08-05 10:49 ` [PATCH 8/8] ARM: dts: AM437x-gp-evm: Enable RTC Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150805114357.GG3486@piout.net \
--to=alexandre.belloni-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=j-keerthy-l0cyMroinI0@public.gmane.org \
--cc=johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nm-l0cyMroinI0@public.gmane.org \
--cc=paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org \
--cc=t-kristo-l0cyMroinI0@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).