From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH 1/8] ARM: dts: AM4372: Reorder the rtc compatible string Date: Thu, 6 Aug 2015 09:16:18 -0500 Message-ID: <20150806141618.GA19110@saruman.tx.rr.com> References: <1438771792-12604-1-git-send-email-j-keerthy@ti.com> <1438771792-12604-2-git-send-email-j-keerthy@ti.com> <20150805153148.GB12328@saruman.tx.rr.com> <55C230E9.9010309@ti.com> <20150805161445.GF12328@saruman.tx.rr.com> <55C23740.2080102@ti.com> <20150805165122.GH12328@saruman.tx.rr.com> <55C2B7A5.5000400@ti.com> Reply-To: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qDbXVdCdHGoSgWSk" Return-path: Content-Disposition: inline In-Reply-To: <55C2B7A5.5000400-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Keerthy Cc: balbi-l0cyMroinI0@public.gmane.org, Keerthy , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, nm-l0cyMroinI0@public.gmane.org, paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org, t-kristo-l0cyMroinI0@public.gmane.org List-Id: devicetree@vger.kernel.org --qDbXVdCdHGoSgWSk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 06, 2015 at 06:55:57AM +0530, Keerthy wrote: >=20 >=20 > On Wednesday 05 August 2015 10:21 PM, Felipe Balbi wrote: > >On Wed, Aug 05, 2015 at 09:48:08PM +0530, Keerthy wrote: > >> > >> > >>On Wednesday 05 August 2015 09:44 PM, Felipe Balbi wrote: > >>>On Wed, Aug 05, 2015 at 09:21:05PM +0530, Keerthy wrote: > >>>>Felipe, > >>>> > >>>>On Wednesday 05 August 2015 09:01 PM, Felipe Balbi wrote: > >>>>>On Wed, Aug 05, 2015 at 04:19:45PM +0530, Keerthy wrote: > >>>>>>Compared to da830-rtc compatibility am3352-rtc is more compatible to > >>>>>>the one in am437x. Hence adding the am3352-rtc compatible to cover = the > >>>>>>entire feature set. > >>>>>> > >>>>>>The ti,am4372-rtc has no Documentation and not used even in the dri= ver > >>>>>>hence removing it. > >>>>> > >>>>>why don't you do the inverse ? Document am4372-rtc and make driver u= se > >>>>>it ? > >>>> > >>>>am3352-rtc suffices for am4372 too. No need to add additional one for > >>>>am4372. > >>> > >>>Until we end up needing it, right ? :-) > >>> > >>>Besides, it's already used in a DTS. What happens if someone branched > >>>from that DTS and ships that in a product. RTC will just stop working > >>>for them. Sure, it wasn't documented, but that's a problem of commit > >>>73456012734b80442b33916406cfd13bf1b73acb (ARM: dts: AM4372: add few > >>>nodes) which, essentially, added that compatible flag without > >>>documenting it. > >>> > >>>BTW, this compatible has been in tree since August 2013, IMO it's unfar > >>>to drop it just like that. Documenting it would be a better approach. > >> > >>Okay. Can you point me to a file which is already accessing it in dts? > > > >Accessing what ? Also, once DTS reaches a major kernel release, it's > >deemed stable and should be supported. Are we dropping that ? >=20 > I meant getting used in any other dts files than the one i just dropped i= t. how can you ever know that for sure ? There are already quite a few third party platforms based on AM437x, how can you be sure those companies don't have their own DTS ? --=20 balbi --qDbXVdCdHGoSgWSk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVw2wyAAoJEIaOsuA1yqREs74P+wW7SmbiO49XlzI9VEHiKPH2 UWg8VgzkLGk5WPJDIFAuSyxH0SfJykYoXZjJJevWauDT4tDnD4HeIxe4XqQTliTC jwTswJ4zJlJhPWSlUvi2BEEXNBYU0VNir5Xx+SZMSQIoiSRdlXT15yvzFz2dZl9n NPGmTJ8283sLsXT6B+VMCKplG9O7nODo7nPO0zOG3lD/lNwL/O1AeBp2pysxspGr 0NMr4MiIN1LY8sedm59XuMXyzn8Xdq36GldN34UMhUF8aaIF5/6lMWBEKQiX3WbF nBV+7XvwZLoTbQVyAO6hVJFQDT9LzAvNZlYzmcKo+5sNvvFdjH5qGF08vBLxxTsE cfwcHuS1hhl+oBIoVkxdAc/qXSkxHkvC7R+1P909M/Rjirzowg18LDwnrm5Krh0W ckMttIM9YinWpHnHXv/znUQBhu9JG5QUDcmW3Zui/pekEWn5rN9YbWgvhUGbp5R6 0Q+09O69YAnKQB9jyo7AUAB74D9n++rpnEzAAhRum6tYKi4bEzffWMEeE40dJLdt MfuD7gEeWamDLZj8MP+x2G4uRrWuM1D/klCrIieAgMXsVP+1+/knh+Zed31lXZaR AW0YzQKhsOvp8Gp5yz6T0H5NH+AuD4MRQIbLhH/WkkJ87x0e/f8iJPUX822+9ncn TBrFCUQ/OmFjZRcflVqX =Q7vR -----END PGP SIGNATURE----- --qDbXVdCdHGoSgWSk-- -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html