From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs Date: Tue, 11 Aug 2015 12:54:25 +0100 Message-ID: <20150811115425.GE18282@x1> References: <20150729081403.GH2284@x1> <20150729221526.GE3159@codeaurora.org> <20150730084634.GD9319@x1> <20150731163715.GV3159@codeaurora.org> <20150803034642.GV899@linux> <20150810132247.GH3249@x1> <20150811080023.GB5509@linux> <20150811093039.GA18282@x1> <20150811100941.GG5509@linux> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20150811100941.GG5509@linux> Sender: linux-pm-owner@vger.kernel.org To: Viresh Kumar Cc: Stephen Boyd , Rob Herring , Nishanth Menon , kernel@stlinux.com, "linux-pm@vger.kernel.org" , Dmitry Eremin-Solenikov , Rafael Wysocki , "linux-kernel@vger.kernel.org" , Sebastian Reichel , "devicetree@vger.kernel.org" , Arnd Bergmann , Ajit Pal Singh , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On Tue, 11 Aug 2015, Viresh Kumar wrote: > On 11-08-15, 10:30, Lee Jones wrote: > > On Tue, 11 Aug 2015, Viresh Kumar wrote: > >=20 > > > On 10-08-15, 14:22, Lee Jones wrote: > > > > > Optional properties: > > > > > +- opp-cuts: One or more strings, describing the versions of = hardware the OPPs > > > > > + can support. > > > >=20 > > > > This isn't very generic. > > > >=20 > > > > I'm guessing some vendors my have quite a few ways to different= iate > > > > between board versions/revisions/cuts etc. > > > >=20 > > > > How about another array where a vendor can choose to identify a= piece > > > > of hardware however they see fit. > > > >=20 > > > > Example 1 (simple version): > > > >=20 > > > > /* Version 1 */ > > > > opp-version =3D <1>; > > > >=20 > > > > Example 2 (using the kernel's versioning): > > > >=20 > > > > /* 2.6.32-rc1 */ > > > > opp-version =3D <2 6 32 1>; > > > >=20 > > > > Example 3 (using ST's versioning): > > > >=20 > > > > /* Major 2, Minor 0, Cut 2, All substrates */ > > > > opp-version =3D <2 0 2 0xff>; > > >=20 > > > But how will we parse this with generic code ? > >=20 > > Why would you want to? >=20 > So that individual platforms don't need to reinvent the wheel ? The framework does not need to parse this information. It is used solely by the platform driver, whose job it is to decide which OPPs are appropriate for the running platform. Back to my question; how would you like arbitrary version information, which means different things to different vendors to be used in shared/generic/framework code? --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog