From: Michael Turquette <mturquette@linaro.org>
To: Tang Yuantian <Yuantian.Tang@freescale.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Liberman Igal-B31950 <Igal.Liberman@freescale.com>,
Bucur Madalin-Cristian-B32716 <madalin.bucur@freescale.com>,
linux-clk@vger.kernel.org, linux-pm@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Scott Wood <scottwood@freescale.com>
Subject: Re: [RFC PATCH 0/8] clk: qoriq: Move chip-specific knowledge into driver
Date: Tue, 11 Aug 2015 11:25:35 -0700 [thread overview]
Message-ID: <20150811182535.31346.52965@quantum> (raw)
In-Reply-To: <1434682158-7243-1-git-send-email-scottwood@freescale.com>
Hi Scott,
Quoting Scott Wood (2015-06-18 19:49:10)
> The existing device tree bindings are error-prone and inflexible.
> Correct the mistake by moving the knowledge into the driver, which
> has more flexibility in describing the quirks of each chip. This leaves
> the device tree to its proper role of identifying a programming interface
> rather than describing its individual registers.
Sorry for not responding to this one sooner. Fell through the cracks.
All of the changes to drives/clk/clk-qoriq.c look great to me. I assume
you need to keep all of these patches together and want to the take
through the freescale tree? If so feel free to add,
Acked-by: Michael Turquette <mturquette@baylibre.com>
Regards,
Mike
>
> For more detail, see the commit message of patch 4.
>
> Scott Wood (8):
> ARM: dts: ls1021a: Fix clockgen node
> cpufreq: qoriq: Don't look at clock implementation details
> powerpc/fsl: Move fsl_guts.h out of arch/powerpc
> clk: qoriq: Move chip-specific knowledge into driver
> clk: qoriq: Redirect legacy clock nodes to new clocks
> cpufreq: qoriq: Remove frequency masking and minimum
> clk: qoriq: Expose OF clocks directly from the clockgen node
> powerpc/fsl: Use new clockgen binding
>
> .../devicetree/bindings/clock/qoriq-clock.txt | 57 +-
> arch/arm/boot/dts/ls1021a.dtsi | 3 +
> arch/powerpc/boot/dts/fsl/b4420si-pre.dtsi | 4 +-
> arch/powerpc/boot/dts/fsl/b4860si-pre.dtsi | 8 +-
> arch/powerpc/boot/dts/fsl/b4si-post.dtsi | 15 -
> arch/powerpc/boot/dts/fsl/p2041si-post.dtsi | 18 -
> arch/powerpc/boot/dts/fsl/p2041si-pre.dtsi | 8 +-
> arch/powerpc/boot/dts/fsl/p3041si-post.dtsi | 18 -
> arch/powerpc/boot/dts/fsl/p3041si-pre.dtsi | 8 +-
> arch/powerpc/boot/dts/fsl/p4080si-post.dtsi | 70 --
> arch/powerpc/boot/dts/fsl/p4080si-pre.dtsi | 16 +-
> arch/powerpc/boot/dts/fsl/p5020si-pre.dtsi | 4 +-
> arch/powerpc/boot/dts/fsl/p5040si-post.dtsi | 18 -
> arch/powerpc/boot/dts/fsl/p5040si-pre.dtsi | 8 +-
> arch/powerpc/boot/dts/fsl/qoriq-clockgen1.dtsi | 50 +-
> arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi | 33 +-
> arch/powerpc/boot/dts/fsl/t1023si-post.dtsi | 16 -
> arch/powerpc/boot/dts/fsl/t102xsi-pre.dtsi | 4 +-
> arch/powerpc/boot/dts/fsl/t1040si-post.dtsi | 44 -
> arch/powerpc/boot/dts/fsl/t104xsi-pre.dtsi | 8 +-
> arch/powerpc/boot/dts/fsl/t2081si-post.dtsi | 22 -
> arch/powerpc/boot/dts/fsl/t208xsi-pre.dtsi | 8 +-
> arch/powerpc/boot/dts/fsl/t4240si-post.dtsi | 61 -
> arch/powerpc/boot/dts/fsl/t4240si-pre.dtsi | 24 +-
> arch/powerpc/platforms/85xx/mpc85xx_mds.c | 2 +-
> arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 2 +-
> arch/powerpc/platforms/85xx/p1022_ds.c | 2 +-
> arch/powerpc/platforms/85xx/p1022_rdk.c | 2 +-
> arch/powerpc/platforms/85xx/smp.c | 2 +-
> arch/powerpc/platforms/85xx/twr_p102x.c | 2 +-
> arch/powerpc/platforms/86xx/mpc8610_hpcd.c | 2 +-
> drivers/clk/clk-qoriq.c | 1191 ++++++++++++++++----
> drivers/cpufreq/qoriq-cpufreq.c | 139 +--
> drivers/iommu/fsl_pamu.c | 2 +-
> .../asm/fsl_guts.h => include/linux/fsl/guts.h | 6 +-
> sound/soc/fsl/mpc8610_hpcd.c | 2 +-
> sound/soc/fsl/p1022_ds.c | 2 +-
> sound/soc/fsl/p1022_rdk.c | 2 +-
> 38 files changed, 1107 insertions(+), 776 deletions(-)
> rename arch/powerpc/include/asm/fsl_guts.h => include/linux/fsl/guts.h (98%)
>
> --
> 2.1.4
>
next prev parent reply other threads:[~2015-08-11 18:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 2:49 [RFC PATCH 0/8] clk: qoriq: Move chip-specific knowledge into driver Scott Wood
[not found] ` <1434682158-7243-1-git-send-email-scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-06-19 2:49 ` [RFC PATCH 1/8] ARM: dts: ls1021a: Fix clockgen node Scott Wood
2015-06-19 2:49 ` [RFC PATCH 2/8] cpufreq: qoriq: Don't look at clock implementation details Scott Wood
2015-06-19 2:49 ` [RFC PATCH 3/8] powerpc/fsl: Move fsl_guts.h out of arch/powerpc Scott Wood
2015-06-19 2:49 ` [RFC PATCH 4/8] clk: qoriq: Move chip-specific knowledge into driver Scott Wood
2015-06-19 2:49 ` [RFC PATCH 5/8] clk: qoriq: Redirect legacy clock nodes to new clocks Scott Wood
2015-06-19 2:49 ` [RFC PATCH 6/8] cpufreq: qoriq: Remove frequency masking and minimum Scott Wood
2015-06-19 2:49 ` [RFC PATCH 7/8] clk: qoriq: Expose OF clocks directly from the clockgen node Scott Wood
2015-06-19 2:49 ` [RFC PATCH 8/8] powerpc/fsl: Use new clockgen binding Scott Wood
[not found] ` <1434682158-7243-9-git-send-email-scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-07-30 15:32 ` Liberman Igal
2015-08-11 18:25 ` Michael Turquette [this message]
2015-08-15 6:43 ` [RFC PATCH 0/8] clk: qoriq: Move chip-specific knowledge into driver Scott Wood
2015-10-02 0:23 ` Scott Wood
2015-10-02 0:26 ` Scott Wood
2015-10-09 23:57 ` Scott Wood
2015-10-22 10:11 ` Michael Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150811182535.31346.52965@quantum \
--to=mturquette@linaro.org \
--cc=Igal.Liberman@freescale.com \
--cc=Yuantian.Tang@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=madalin.bucur@freescale.com \
--cc=rjw@rjwysocki.net \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).