From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v3 3/4] edac: Add L3/SoC EDAC support to the APM X-Gene SoC EDAC driver Date: Thu, 13 Aug 2015 05:36:40 +0200 Message-ID: <20150813033640.GB14432@nazgul.tnic> References: <1439326077-25507-1-git-send-email-lho@apm.com> <1439326077-25507-2-git-send-email-lho@apm.com> <1439326077-25507-3-git-send-email-lho@apm.com> <1439326077-25507-4-git-send-email-lho@apm.com> <20150812105121.GE14011@nazgul.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Loc Ho Cc: Doug Thompson , Mauro Carvalho Chehab , Arnd Bergmann , Rob Herring , Mark Rutland , Ian Campbell , linux-edac-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Jon Masters , "patches-qTEPVZfXA3Y@public.gmane.org" List-Id: devicetree@vger.kernel.org On Wed, Aug 12, 2015 at 10:50:52AM -0700, Loc Ho wrote: > I intentional left this code as is so that the driver will still works > with older version of the EDAC code. Huh, what? I don't think this is how upstream development works. > I had already reversed the logic for the L3 and SoC. Are you asking > for the MC/PMD (earlier posting)? The MC/PMD routine isn't that big. > Functions in general fit in an screen of 80 column? Only for the ones where it becomes clumsy and flipping it would make the code more readable. I'm not a hard 80 cols follower anyway. > So, is there something that I am missing? I hope you're not. But seeing the custom debugfs stuff left in the new submission without any comment as to *why* you've left it, made me think you didn't incorporate all feedback. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html