From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v3 1/4] edac: Add an function to retrieve the EDAC debugfs node Date: Thu, 13 Aug 2015 10:15:37 +0200 Message-ID: <20150813081537.GB20004@nazgul.tnic> References: <1439326077-25507-1-git-send-email-lho@apm.com> <1439326077-25507-2-git-send-email-lho@apm.com> <20150812101219.GC14011@nazgul.tnic> <20150812104954.GD14011@nazgul.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Loc Ho Cc: Doug Thompson , Mauro Carvalho Chehab , Arnd Bergmann , Rob Herring , Mark Rutland , Ian Campbell , linux-edac-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Jon Masters , "patches-qTEPVZfXA3Y@public.gmane.org" List-Id: devicetree@vger.kernel.org On Wed, Aug 12, 2015 at 09:30:58PM -0700, Loc Ho wrote: > Okay... The 'inline' helps with the compiler warning. If I move all to > header file with 'static inline' and wrapper around CONFIG_EDAC_DEBUG, > don't I need to export and declare the variable 'edac_debugfs'? Are > you okay with export this variable? You need to make edac_debugfs extern in the header and define it in edac_mc_sysfs.c. But that's ok because edac_core.h will be included only by EDAC drivers and they're supposed to see edac_debugfs anyway... Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html