Re: [PATCH v3 1/4] edac: Add an function to retrieve the EDAC debugfs node

[Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>]

On Thu, Aug 13, 2015 at 10:41:50AM +0200, Lothar Waßmann wrote:
> What's the point in having an accessor function that returns a driver
> internal variable when this variable is exported anyway?

Not driver-internal but EDAC-core internal.

> This will only further inconsistencies because half of the users will
> use the variable directly and the other half will use the accessor
> function.

The idea is that it is not visible outside of EDAC. The EDAC drivers
themselves should see it. And yes, I admit that the accessors are maybe
redundant then since EDAC drivers can use edac_debugfs ptr directly.

Hmm, and that's ok too because my other concern about future refactoring
is taken care of too because as long as all users of edac_debugfs are
confined to drivers/edac/, changing stuff there is easy.

Ok, I'm convinced, Loc, feel free to drop the accessors in your next
version.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html